Changeset 10542 for trunk/src/bp-activity/bp-activity-template.php

Timestamp:

02/07/2016 04:29:52 PM (10 years ago)

Author:

imath

Message:

Post Type Activities: allow post types to register comments tracking

When registering a post type, it is now possible to inform BuddyPress the comments about this post type need to be tracked into the activity stream. This can be achieved by making sure the post type supports "comments" and "buddypress-activity" and by adding extra parameters to the "bp_activity" argument of the register_post_type() function one or by using the bp_activity_set_post_type_tracking_args() function.

We are also introducing a new function to inform if an activity type is supporting a specific feature: bp_activity_type_supports(). For now this function is helping to check if:

• a activity supports a an activity comment
• an activity comment supports synchronization with a post type comment

Props shanebp, r-a-y.

See #6482

File:

• trunk/src/bp-activity/bp-activity-template.php (modified) (2 diffs)

trunk/src/bp-activity/bp-activity-template.php

@@ -3030 +3030 @@
     $bp = buddypress();
 
-    // Assume activity can be commented on.
-    $can_comment = true;
-
-    // Determine ability to comment based on activity action name.
-    $activity_action = bp_get_activity_action_name();
-
-    $turn_off = 0;
-    if ( ! empty( $activities_template->disable_blogforum_replies ) ) {
-        $turn_off = 1;
-    }
-
-    $maybe_turn_off = array_fill_keys( array(
-        'new_blog_post',
-        'new_blog_comment',
-        'new_forum_topic',
-        'new_forum_post',
-    ), $turn_off );
-
-    $maybe_turn_off['activity_comment'] = 1;
-
-    // Fetch all the tracked post types once.
-    if ( empty( $bp->activity->track ) ) {
-        $bp->activity->track = bp_activity_get_post_types_tracking_args();
-    }
-
-    foreach ( $bp->activity->track as $action => $tracking_args ) {
-        if ( empty( $tracking_args->activity_comment ) ) {
-            $maybe_turn_off[ $action ] = $turn_off;
-        }
-    }
-
-    $can_comment = empty( $maybe_turn_off[ $activity_action ] );
+    // Determine ability to comment based on activity type name.
+    $activity_type = bp_get_activity_type();
+
+    // Get the 'comment-reply' support for the current activity type.
+    $can_comment = bp_activity_type_supports( $activity_type, 'comment-reply' );
+
+    // Neutralize activity_comment.
+    if ( 'activity_comment' === $activity_type ) {
+        $can_comment = false;
+    }
 
     /**
@@ -3067 +3045 @@
      *
      * @since 1.5.0
+     * @since 2.5.0 Use $activity_type instead of $activity_name for the second parameter.
      *
      * @param bool   $can_comment     Status on if activity can be commented on.
-     * @param string $activity_action Current activity action being checked on.
-     */
-    return apply_filters( 'bp_activity_can_comment', $can_comment, $activity_action );
+     * @param string $activity_type   Current activity type being checked on.
+     */
+    return apply_filters( 'bp_activity_can_comment', $can_comment, $activity_type );
 }