Changeset 10456

Timestamp:

01/19/2016 07:22:54 PM (11 years ago)

Author:

imath

Message:

Make sure the Sign-ups Administration page is available when BuddyPress is "multiblog" activated.

On multisite configs, when the constant BP_ENABLE_MULTIBLOG is set to true, Sign-ups can be managed from the Users administration of the network.

Props r-a-y, sbrajesh

Fixes #6371

Location:

trunk/src/bp-members

Files:

• admin/bp-members-admin-classes.php (modified) (4 diffs)
• bp-members-admin.php (modified) (5 diffs)

trunk/src/bp-members/admin/bp-members-admin-classes.php

@@ -483 +483 @@
                 // Remove the 'current' class from the 'All' link.
                 $views['all']        = str_replace( 'class="current"', '', $views['all'] );
-                $views['registered'] = sprintf( '<a href="%1$s" class="current">%2$s</a>', esc_url( add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) ), sprintf( _x( 'Pending %s', 'signup users', 'buddypress' ), '<span class="count">(' . number_format_i18n( $this->signup_counts ) . ')</span>' ) );
+                $views['registered'] = sprintf( '<a href="%1$s" class="current">%2$s</a>', esc_url( add_query_arg( 'page', 'bp-signups', network_admin_url( 'users.php' ) ) ), sprintf( _x( 'Pending %s', 'signup users', 'buddypress' ), '<span class="count">(' . number_format_i18n( $this->signup_counts ) . ')</span>' ) );
 
                 return $views;
@@ -647 +647 @@
                                 'action'    => 'resend',
                         ),
-                        bp_get_admin_url( 'users.php' )
+                        network_admin_url( 'users.php' )
                 );
 
@@ -657 +657 @@
                                 'action'    => 'activate',
                         ),
-                        bp_get_admin_url( 'users.php' )
+                        network_admin_url( 'users.php' )
                 );
 
@@ -667 +667 @@
                                 'action'    => 'delete',
                         ),
-                        bp_get_admin_url( 'users.php' )
+                        network_admin_url( 'users.php' )
                 );
 

trunk/src/bp-members/bp-members-admin.php

@@ -203 +203 @@
                         // Reorganise the views navigation in users.php and signups page.
                         if ( current_user_can( $this->capability ) ) {
-                                add_filter( "views_{$this->users_screen}", array( $this, 'signup_filter_view'    ), 10, 1 );
-                                add_filter( 'set-screen-option',           array( $this, 'signup_screen_options' ), 10, 3 );
+                                $user_screen = $this->users_screen;
+
+                                /**
+                                 * Users screen on multiblog is users, but signups
+                                 * need to be managed in the network for this case
+                                 */
+                                if ( bp_is_network_activated() && bp_is_multiblog_mode() && false === strpos( $user_screen, '-network' ) ) {
+                                        $user_screen .= '-network';
+                                }
+
+                                add_filter( "views_{$user_screen}", array( $this, 'signup_filter_view'    ), 10, 1 );
+                                add_filter( 'set-screen-option',    array( $this, 'signup_screen_options' ), 10, 3 );
                         }
                 }
@@ -1325 +1335 @@
 
                 $signups = BP_Signup::count_signups();
-                $url     = add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) );
+
+                if ( is_network_admin() ) {
+                        $base_url = network_admin_url( 'users.php' );
+                } else {
+                        $base_url = bp_get_admin_url( 'users.php' );
+                }
+
+                $url     = add_query_arg( 'page', 'bp-signups', $base_url );
                 $text    = sprintf( _x( 'Pending %s', 'signup users', 'buddypress' ), '<span class="count">(' . number_format_i18n( $signups ) . ')</span>' );
 
@@ -1395 +1412 @@
                 if ( ! in_array( $doaction, $allowed_actions ) || ( -1 == $doaction ) ) {
 
-                        if ( bp_core_do_network_admin() ) {
+                        if ( is_network_admin() ) {
                                 $bp_members_signup_list_table = self::get_list_table_class( 'BP_Members_MS_List_Table', 'ms-users' );
                         } else {
@@ -1784 +1801 @@
                 $bp_members_signup_list_table->prepare_items();
 
+                if ( is_network_admin() ) {
+                        $form_url = network_admin_url( 'users.php' );
+                } else {
+                        $form_url = bp_get_admin_url( 'users.php' );
+                }
+
                 $form_url = add_query_arg(
                         array(
                                 'page' => 'bp-signups',
                         ),
-                        bp_get_admin_url( 'users.php' )
+                        $form_url
                 );
 
@@ -1924 +1947 @@
                 );
 
-                $cancel_url = add_query_arg( $url_args, bp_get_admin_url( 'users.php' ) );
+                if ( is_network_admin() ) {
+                        $base_url = network_admin_url( 'users.php' );
+                } else {
+                        $base_url = bp_get_admin_url( 'users.php' );
+                }
+
+                $cancel_url = add_query_arg( $url_args, $base_url );
                 $action_url = wp_nonce_url(
                         add_query_arg(
                                 array_merge( $url_args, $action_args ),
-                                bp_get_admin_url( 'users.php' )
+                                $base_url
                         ),
                         'signups_' . $action