Changeset 10441

Timestamp:

01/07/2016 04:26:05 PM (9 years ago)

Author:

boonebgorges

Message:

Improved coding standards in BP_Groups_Widget.

Props sbrajesh.
See #6721.

File:

• trunk/src/bp-groups/bp-groups-widgets.php (modified) (12 diffs)

trunk/src/bp-groups/bp-groups-widgets.php

@@ -27 +27 @@
      * Working as a group, we get things done better.
      */
-    function __construct() {
+    public function __construct() {
         $widget_ops = array(
             'description' => __( 'A dynamic list of recently active, popular, and newest groups', 'buddypress' ),
@@ -34 +34 @@
         parent::__construct( false, _x( '(BuddyPress) Groups', 'widget name', 'buddypress' ), $widget_ops );
 
-        if ( is_active_widget( false, false, $this->id_base ) && !is_admin() && !is_network_admin() ) {
+        if ( is_active_widget( false, false, $this->id_base ) && ! is_admin() && ! is_network_admin() ) {
             $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
             wp_enqueue_script( 'groups_widget_groups_list-js', buddypress()->plugin_url . "bp-groups/js/widget-groups{$min}.js", array( 'jquery' ), bp_get_version() );
@@ -46 +46 @@
      * @param array $instance Widget instance data.
      */
-    function widget( $args, $instance ) {
+    public function widget( $args, $instance ) {
 
         /**
@@ -59 +59 @@
         extract( $args );
 
-        if ( empty( $instance['group_default'] ) )
+        if ( empty( $instance['group_default'] ) ) {
             $instance['group_default'] = 'popular';
-
-        if ( empty( $instance['title'] ) )
+        }
+
+        if ( empty( $instance['title'] ) ) {
             $instance['title'] = __( 'Groups', 'buddypress' );
+        }
 
         /**
@@ -88 +90 @@
         echo $before_widget;
 
-        $title = !empty( $instance['link_title'] ) ? '<a href="' . bp_get_groups_directory_permalink() . '">' . $title . '</a>' : $title;
+        $title = ! empty( $instance['link_title'] ) ? '<a href="' . bp_get_groups_directory_permalink() . '">' . $title . '</a>' : $title;
 
         echo $before_title . $title . $after_title;
@@ -124 +126 @@
                                 <span class="activity">
                                 <?php
-                                    if ( 'newest' == $instance['group_default'] )
+                                    if ( 'newest' == $instance['group_default'] ) {
                                         printf( __( 'created %s', 'buddypress' ), bp_get_group_date_created() );
-                                    if ( 'active' == $instance['group_default'] )
+                                    } elseif ( 'active' == $instance['group_default'] ) {
                                         printf( __( 'active %s', 'buddypress' ), bp_get_group_last_active() );
-                                    elseif ( 'popular' == $instance['group_default'] )
+                                    } elseif ( 'popular' == $instance['group_default'] ) {
                                         bp_group_member_count();
+                                    }
                                 ?>
                                 </span>
@@ -160 +163 @@
      * @return array
      */
-    function update( $new_instance, $old_instance ) {
+    public function update( $new_instance, $old_instance ) {
         $instance = $old_instance;
 
@@ -166 +169 @@
         $instance['max_groups']    = strip_tags( $new_instance['max_groups'] );
         $instance['group_default'] = strip_tags( $new_instance['group_default'] );
-        $instance['link_title']    = (bool)$new_instance['link_title'];
+        $instance['link_title']    = (bool) $new_instance['link_title'];
 
         return $instance;
@@ -177 +180 @@
      * @return mixed
      */
-    function form( $instance ) {
+    public function form( $instance ) {
         $defaults = array(
             'title'         => __( 'Groups', 'buddypress' ),
@@ -189 +192 @@
         $max_groups    = strip_tags( $instance['max_groups'] );
         $group_default = strip_tags( $instance['group_default'] );
-        $link_title    = (bool)$instance['link_title'];
+        $link_title    = (bool) $instance['link_title'];
         ?>
 
@@ -212 +215 @@
 function groups_ajax_widget_groups_list() {
 
-    check_ajax_referer('groups_widget_groups_list');
+    check_ajax_referer( 'groups_widget_groups_list' );
 
     switch ( $_POST['filter'] ) {
@@ -267 +270 @@
     <?php else: ?>
 
-        <?php echo "-1[[SPLIT]]<li>" . __("No groups matched the current filter.", 'buddypress'); ?>
+        <?php echo "-1[[SPLIT]]<li>" . __( "No groups matched the current filter.", 'buddypress' ); ?>
 
     <?php endif;