Changeset 10402 for branches/2.4/src/bp-core/bp-core-functions.php

Timestamp:

12/13/2015 04:45:43 PM (10 years ago)

Author:

imath

Message:

Make sure document/page title tags are correctly generated for BuddyPress pages

• Remove all the BuddyPress process to create BuddyPress title parts from bp_modify_page_title() and create the new function

bp_get_title_parts() and put this process here. This allowes plugin/theme to directly use it if needed.

• Keep the filter on wp_title so that themes not supporting the title-tag feature or breadcrumb plugins can still easily get BuddyPress title parts.
• Filter document_title_parts with a new function bp_modify_document_title_parts() to build the BuddyPress title parts if needed.
• Both functions bp_modify_page_title() and bp_modify_document_title_parts() are using bp_get_title_parts().

Props slaFFik, mercime, r-a-y, DJPaul

See #6675 (branch 2.4)

File:

• branches/2.4/src/bp-core/bp-core-functions.php (modified) (2 diffs)

branches/2.4/src/bp-core/bp-core-functions.php

@@ -2297 +2297 @@
 add_action( 'bp_init', 'bp_remove_adjacent_posts_rel_link' );
 
+/**
+ * Strip the span count of a menu item or of a title part.
+ *
+ * @since 2.2.2
+ *
+ * @param string $title_part Title part to clean up.
+ * @return string
+ */
+function _bp_strip_spans_from_title( $title_part = '' ) {
+    $title = $title_part;
+    $span = strpos( $title, '<span' );
+    if ( false !== $span ) {
+        $title = substr( $title, 0, $span - 1 );
+    }
+    return trim( $title );
+}
+
 /** Nav Menu ******************************************************************/
 
@@ -2348 +2365 @@
 
         // Remove <span>number</span>
-        $item_name = preg_replace( '/([.0-9]+)/', '', $bp_item['name'] );
-        $item_name = trim( strip_tags( $item_name ) );
+        $item_name = _bp_strip_spans_from_title( $bp_item['name'] );
 
         $page_args[ $bp_item['slug'] ] = (object) array(