Changeset 10384

Timestamp:

11/28/2015 03:32:24 AM (8 years ago)

Author:

boonebgorges

Message:

Make sure that max_groups is always defined in group widget.

This prevents a notice from being shown when the widget is added in the
Customizer.

Props slaFFik.
See #6754.
Fixes #6747.

File:

• trunk/src/bp-groups/bp-groups-widgets.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-widgets.php

@@ -100 +100 @@
         echo $before_title . $title . $after_title;
 
+        $max_groups = ! empty( $instance['max_groups'] ) ? (int) $instance['max_groups'] : 5;
+
         $group_args = array(
             'user_id'         => $user_id,
             'type'            => $instance['group_default'],
-            'per_page'        => $instance['max_groups'],
-            'max'             => $instance['max_groups'],
+            'per_page'        => $max_groups,
+            'max'             => $max_groups,
         );
 
@@ -145 +147 @@
             </ul>
             <?php wp_nonce_field( 'groups_widget_groups_list', '_wpnonce-groups' ); ?>
-            <input type="hidden" name="groups_widget_max" id="groups_widget_max" value="<?php echo esc_attr( $instance['max_groups'] ); ?>" />
+            <input type="hidden" name="groups_widget_max" id="groups_widget_max" value="<?php echo esc_attr( $max_groups ); ?>" />
 
         <?php else: ?>