Changeset 10376 for branches/2.4/src/bp-core/bp-core-caps.php

Timestamp:

11/25/2015 07:23:55 PM (4 years ago)

Author:

r-a-y

Message:

Caps: Fix issue with passing an empty array as an argument in bp_current_user_can().

Changes to bp_current_user_can() in #6501 broke older capability checks
relying on an empty argument to be passed in order to use a fallback value.

Most notably, bp_current_user_can('bp_xprofile_change_field_visibility' )
checks now passed by default. This resulted in the "Change" link to
always be visible when editing a profile field even if an admin has enabled
"Enforce field visibility" for that particular field.

This commit fixes this issue by passing a null value if there are no
extra arguments to pass in bp_current_user_can(). Commit also includes
a unit test.

See #6730 (2.4-branch).

File:

• branches/2.4/src/bp-core/bp-core-caps.php (modified) (1 diff)

branches/2.4/src/bp-core/bp-core-caps.php

@@ -292 +292 @@
     }
 
+    // Backward compatibility for older bp_current_user_can() checks
+    if ( empty( $args ) ) {
+        $args = null;
+    }
+
     // Use root blog if no ID passed
     if ( empty( $blog_id ) ) {