Changeset 10294

Timestamp:

10/21/2015 06:57:52 PM (11 years ago)

Author:

r-a-y

Message:

bp-legacy: Pass all $_POST data when a user makes a "What's New" activity update.

Previously, if a plugin developer added a custom field to the "What's New"
form, the data for that field would not get passed to our AJAX post handler

• bp_legacy_theme_post_update(). This made things difficult for plugin

developers to save their custom activity data.

This commit passes all valid $_POST fields from the "What's New" form to
our AJAX post handler, which will allow plugin developers to find their
data and save it.

See ​https://buddypress.trac.wordpress.org/ticket/6569#comment:21 for a
brief example.

Props imath.

See #6569.

File:

• trunk/src/bp-templates/bp-legacy/js/buddypress.js (modified) (4 diffs)

trunk/src/bp-templates/bp-legacy/js/buddypress.js

@@ -105 +105 @@
                 var last_date_recorded = 0,
                         button = jq(this),
-                        form   = button.closest('form#whats-new-form');
-
-                form.children().each( function() {
-                        if ( jq.nodeName(this, 'textarea') || jq.nodeName(this, 'input') ) {
+                        form   = button.closest('form#whats-new-form'),
+                        inputs = {}, post_data;
+
+                // Get all inputs and organize them into an object {name: value}
+                jq.each( form.serializeArray(), function( key, input ) {
+                        // Only include public extra data
+                        if ( '_' !== input.name.substr( 0, 1 ) && 'whats-new' !== input.name.substr( 0, 9 ) ) {
+                                if ( ! inputs[ input.name ] ) {
+                                        inputs[ input.name ] = input.value;
+                                } else {
+                                        // Checkboxes/dropdown list can have multiple selected value
+                                        if ( ! jq.isArray( inputs[ input.name ] ) ) {
+                                                inputs[ input.name ] = new Array( inputs[ input.name ], input.value );
+                                        } else {
+                                                inputs[ input.name ].push( input.value );
+                                        }
+                                }
+                        }
+                } );
+
+                form.find( '*' ).each( function() {
+                        if ( jq.nodeName( this, 'textarea' ) || jq.nodeName( this, 'input' ) ) {
                                 jq(this).prop( 'disabled', true );
                         }
-                });
+                } );
 
                 /* Remove any errors */
@@ -146 +164 @@
                 }
 
-                jq.post( ajaxurl, {
+                post_data = jq.extend( {
                         action: 'post_update',
                         'cookie': bp_get_cookies(),
@@ -155 +173 @@
                         'since': last_date_recorded,
                         '_bp_as_nonce': jq('#_bp_as_nonce').val() || ''
-                },
-                function(response) {
-
-                        form.children().each( function() {
-                                if ( jq.nodeName(this, 'textarea') || jq.nodeName(this, 'input') ) {
+                }, inputs );
+
+                jq.post( ajaxurl, post_data, function( response ) {
+                        form.find( '*' ).each( function() {
+                                if ( jq.nodeName( this, 'textarea' ) || jq.nodeName( this, 'input' ) ) {
                                         jq(this).prop( 'disabled', false );
                                 }
@@ -206 +224 @@
                                 jq('li.new-update').removeClass( 'new-update' );
                                 jq('#whats-new').val('');
+                                form.get(0).reset();
 
                                 // reset vars to get newest activities