Changeset 10286 for trunk/tests/phpunit/testcases/messages/functions.php

Timestamp:

10/19/2015 07:47:01 PM (11 years ago)

Author:

r-a-y

Message:

Messages: Return context-appropriate error messages for messages_new_message().

This commit introduces the error_type parameter in the
messages_new_message() function, which allows for us to return
descriptive error messages to the user when 'error_type' is set to
'wp_error'.

This most notably addresses an issue when entering an invalid username
when composing a new private message.

Commit also includes a unit test.

Fixes #6535.

File:

• trunk/tests/phpunit/testcases/messages/functions.php (modified) (1 diff)

trunk/tests/phpunit/testcases/messages/functions.php

@@ -42 +42 @@
         }
 
+        /**
+         * @group messages_new_message
+         */
+        public function test_messages_new_message_invalid_recipient_error_message() {
+                $u1 = $this->factory->user->create();
+
+                // attempt to send a private message to an invalid username
+                $t1 = messages_new_message( array(
+                        'sender_id'  => $u1,
+                        'recipients' => array( 'homerglumpkin' ),
+                        'subject'    => 'A new message',
+                        'content'    => 'Hey there!',
+                        'error_type' => 'wp_error'
+                ) );
+
+                $this->assertSame( 'Message could not be sent because you have entered an invalid username. Please try again.', $t1->get_error_message() );
+        }
 }