Changeset 10243

Timestamp:

10/11/2015 12:52:31 PM (9 years ago)

Author:

djpaul

Message:

xprofile: fix PHP notice when adding new profile field with no name

When adding a new profile field in wp-admin, clicking save without
entering the field name can cause a PHP notice because the
“sort_order_{field_type}” property is not set for every field type.

File:

• trunk/src/bp-xprofile/classes/class-bp-xprofile-field.php (modified) (1 diff)

trunk/src/bp-xprofile/classes/class-bp-xprofile-field.php

@@ -1105 +1105 @@
                 $this->is_required = $_POST['required'];
                 $this->type        = $_POST['fieldtype'];
-                $this->order_by    = $_POST["sort_order_{$this->type}"];
                 $this->field_order = $_POST['field_order'];
+
+                if ( ! empty( $_POST["sort_order_{$this->type}"] ) ) {
+                    $this->order_by = $_POST["sort_order_{$this->type}"];
+                }
             }
         } else {