Changeset 10237

Timestamp:

10/10/2015 06:50:10 PM (9 years ago)

Author:

djpaul

Message:

bp-legacy: fix nonce and message when requesting private group membership

The AJAX handler for the “request private group membership” button was
sending the wrong nonce in its response when you leave a private group.
The button refreshes its label to read “request membership” but as the
nonce was wrong, only “-1” was printed to the screen. Nothing actually
happened.

By coincidence, this is one of those legacy parts of BuddyPress where
markup is shared between a template file and inside an AJAX callback
function in the PHP. While resolving that duplication is beyond the
scope of this immediate change, the AJAX version of the template has
been updated to match the template file (the only change is the button
label).

Fixes #5790

Props lakrisgubben

Location:

trunk/src/bp-templates/bp-legacy

Files:

• buddypress-functions.php (modified) (2 diffs)
• css/buddypress-rtl.css (modified) (1 diff)
• css/buddypress.css (modified) (1 diff)

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -1497 +1497 @@
                     _e( 'Error requesting membership', 'buddypress' );
                 } else {
-                    echo '<a id="group-' . esc_attr( $group->id ) . '" class="membership-requested" rel="membership-requested" title="' . __( 'Membership Requested', 'buddypress' ) . '" href="' . bp_get_group_permalink( $group ) . '">' . __( 'Membership Requested', 'buddypress' ) . '</a>';
+                    echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button disabled pending membership-requested" rel="membership-requested" title="' . __( 'Request Sent', 'buddypress' ) . '" href="' . bp_get_group_permalink( $group ) . '">' . __( 'Request Sent', 'buddypress' ) . '</a>';
                 }
             }
@@ -1510 +1510 @@
             echo '<a id="group-' . esc_attr( $group->id ) . '" class="join-group" rel="join" title="' . __( 'Join Group', 'buddypress' ) . '" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'join', 'groups_join_group' ) . '">' . __( 'Join Group', 'buddypress' ) . '</a>';
         } elseif ( 'private' == $group->status ) {
-            echo '<a id="group-' . esc_attr( $group->id ) . '" class="request-membership" rel="join" title="' . __( 'Request Membership', 'buddypress' ) . '" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'request-membership', 'groups_send_membership_request' ) . '">' . __( 'Request Membership', 'buddypress' ) . '</a>';
+            echo '<a id="group-' . esc_attr( $group->id ) . '" class="request-membership" rel="join" title="' . __( 'Request Membership', 'buddypress' ) . '" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'request-membership', 'groups_request_membership' ) . '">' . __( 'Request Membership', 'buddypress' ) . '</a>';
         }
     }

trunk/src/bp-templates/bp-legacy/css/buddypress-rtl.css

@@ -779 +779 @@
 #buddypress input[type=reset],
 #buddypress ul.button-nav li a,
-#buddypress div.generic-button a,
+#buddypress .generic-button a,
 #buddypress .comment-reply-link,
 a.bp-title-button {

trunk/src/bp-templates/bp-legacy/css/buddypress.css

@@ -779 +779 @@
 #buddypress input[type=reset],
 #buddypress ul.button-nav li a,
-#buddypress div.generic-button a,
+#buddypress .generic-button a,
 #buddypress .comment-reply-link,
 a.bp-title-button {