Changeset 10232 for trunk/src/bp-xprofile/bp-xprofile-functions.php

Timestamp:

10/10/2015 04:13:02 PM (9 years ago)

Author:

djpaul

Message:

xprofile: remove is_admin() logic from required field check

The function should return the same thing for everyone, as it’s a
property of the field only (not the field-user combo). In the relevant
places where these functions are used in BP - namely, during form
submission - bp_moderate users are able to bypass the requirement.

This change breaks backwards compatibility in cases where the
field_is_required() functions are called directly, and the plugin
expects the function to return true for bp_moderate users. This is
unlikely, and given that if there were, they’d run into this same bug,
let’s fix it.

Fixes #6520

Props boonebgorges

File:

• trunk/src/bp-xprofile/bp-xprofile-functions.php (modified) (1 diff)

trunk/src/bp-xprofile/bp-xprofile-functions.php

@@ -541 +541 @@
 
 function xprofile_check_is_required_field( $field_id ) {
-    $field = new BP_Xprofile_Field( $field_id );
-
-    // Define locale variable(s).
+    $field  = new BP_Xprofile_Field( $field_id );
     $retval = false;
 
-    // Super admins can skip required check.
-    if ( bp_current_user_can( 'bp_moderate' ) && ! is_admin() ) {
-        $retval = false;
-
-    // All other users will use the field's setting.
-    } elseif ( isset( $field->is_required ) ) {
+    if ( isset( $field->is_required ) ) {
         $retval = $field->is_required;
     }