Changeset 10223 for trunk/tests/phpunit/testcases/core/class-bp-media-extractor.php

Timestamp:

10/08/2015 10:27:17 PM (10 years ago)

Author:

djpaul

Message:

Tests: try to re-implement media extractor test for WP 4.4 compat

File:

• trunk/tests/phpunit/testcases/core/class-bp-media-extractor.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/core/class-bp-media-extractor.php

@@ -325 +325 @@
 
     public function test_extract_images_from_content_with_galleries_variant_ids() {
-        // To test the [gallery] shortcode, we need to create a post and attachments.
-        $attachment_ids = array();
-        foreach ( range( 1, 3 ) as $i ) {
-            $attachment_id = $this->factory->attachment->create_object( "image{$i}.jpg", 0, array(
-                'post_mime_type' => 'image/jpeg',
-                'post_type'      => 'attachment'
-            ) );
-
-            wp_update_attachment_metadata( $attachment_id, array( 'width' => 100, 'height' => 100 ) );
-            $attachment_ids[] = $attachment_id;
-        }
-
-        $attachment_ids = join( ',', $attachment_ids );
-        $post_id        = $this->factory->post->create( array( 'post_content' => "[gallery ids='{$attachment_ids}']" ) );
-
+        $attachment_ids   = array();
+        $attachment_ids[] = $this->fake_attachment_upload( DIR_TESTDATA . '/images/test-image-large.png' );
+        $attachment_ids[] = $this->fake_attachment_upload( DIR_TESTDATA . '/images/canola.jpg' );
+        $attachment_ids   = join( ',', $attachment_ids );
+        $post_id          = $this->factory->post->create( array( 'post_content' => "[gallery ids='{$attachment_ids}']" ) );
 
         // Extract the gallery images.
@@ -348 +338 @@
         $this->assertArrayHasKey( 'images', $media );
         $media = array_values( wp_list_filter( $media['images'], array( 'source' => 'galleries' ) ) );
-        $this->assertCount( 3, $media );
-
-        for ( $i = 1; $i <= 3; $i++ ) {
-            $this->assertSame( 'http://' . WP_TESTS_DOMAIN . "/wp-content/uploads/image{$i}.jpg", $media[ $i - 1 ]['url'] );
-        }
+        $this->assertCount( 2, $media );
+
+        $this->assertSame( 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/test-image-large.png', $media[0]['url'] );
+        $this->assertSame( 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/canola.jpg', $media[1]['url'] );
     }