Changeset 10198 for trunk/tests/phpunit/testcases/xprofile/functions.php

Timestamp:

10/07/2015 02:30:31 PM (11 years ago)

Author:

boonebgorges

Message:

Introduce cache support for xprofile fields.

xprofile_get_field() will now look in the cache before returning a
BP_XProfile_Field object (via the new BP_XProfile_Field::get_instance()),
and will populate the cache if necessary. It's strongly recommended to use
xprofile_get_field() when fetching individual existing fields, instead of
creating new BP_XProfile_Field objects directly.

BP_XProfile_Group::get() now leverages the field cache too. Instead of a
SELECT * query, it fetches a list of matching field IDs SELECT id, and
populates the full field objects from the cache, if available. The fields
property of BP_XProfile_Group objects is now an array of BP_XProfile_Field
objects, not stdClass. See #6358.

Props boonebgorges, r-a-y.
See #6638.

File:

• trunk/tests/phpunit/testcases/xprofile/functions.php (modified) (1 diff)

trunk/tests/phpunit/testcases/xprofile/functions.php

@@ -869 +869 @@
                 $this->assertEquals( array( 1, $g1, $g3, $g2 ), wp_list_pluck( $field_groups, 'id' ) );
         }
+
+        /**
+         * @ticket BP6638
+         */
+        public function test_xprofile_get_field_should_return_bp_xprofile_field_object() {
+                global $wpdb;
+
+                $g = $this->factory->xprofile_group->create();
+                $f = $this->factory->xprofile_field->create( array(
+                        'field_group_id' => $g,
+                        'type' => 'selectbox',
+                        'name' => 'Foo',
+                ) );
+
+                $field = xprofile_get_field( $f );
+
+                $this->assertTrue( $field instanceof BP_XProfile_Field );
+        }
+
+        /**
+         * @ticket BP6638
+         * @group cache
+         */
+        public function test_xprofile_get_field_should_prime_field_cache() {
+                global $wpdb;
+
+                $g = $this->factory->xprofile_group->create();
+                $f = $this->factory->xprofile_field->create( array(
+                        'field_group_id' => $g,
+                        'type' => 'selectbox',
+                        'name' => 'Foo',
+                ) );
+
+                $num_queries = $wpdb->num_queries;
+
+                // Prime the cache.
+                $field_1 = xprofile_get_field( $f );
+                $num_queries++;
+                $this->assertSame( $num_queries, $wpdb->num_queries );
+
+                // No more queries.
+                $field_2 = xprofile_get_field( $f );
+                $this->assertEquals( $field_1, $field_2 );
+                $this->assertSame( $num_queries, $wpdb->num_queries );
+        }
 }