Changeset 10198 for trunk/src/bp-xprofile/classes/class-bp-xprofile-group.php

Timestamp:

10/07/2015 02:30:31 PM (9 years ago)

Author:

boonebgorges

Message:

Introduce cache support for xprofile fields.

xprofile_get_field() will now look in the cache before returning a
BP_XProfile_Field object (via the new BP_XProfile_Field::get_instance()),
and will populate the cache if necessary. It's strongly recommended to use
xprofile_get_field() when fetching individual existing fields, instead of
creating new BP_XProfile_Field objects directly.

BP_XProfile_Group::get() now leverages the field cache too. Instead of a
SELECT * query, it fetches a list of matching field IDs SELECT id, and
populates the full field objects from the cache, if available. The fields
property of BP_XProfile_Group objects is now an array of BP_XProfile_Field
objects, not stdClass. See #6358.

Props boonebgorges, r-a-y.
See #6638.

File:

• trunk/src/bp-xprofile/classes/class-bp-xprofile-group.php (modified) (1 diff)

trunk/src/bp-xprofile/classes/class-bp-xprofile-group.php

@@ -370 +370 @@
 
         // Fetch the fields.
-        $fields = $wpdb->get_results( "SELECT id, name, description, type, group_id, is_required FROM {$bp->profile->table_name_fields} WHERE group_id IN ( {$group_ids_in} ) AND parent_id = 0 {$exclude_fields_sql} {$in_sql} ORDER BY field_order" );
-
-        $field_ids = wp_list_pluck( $fields, 'id' );
+        $field_ids = $wpdb->get_col( "SELECT id FROM {$bp->profile->table_name_fields} WHERE group_id IN ( {$group_ids_in} ) AND parent_id = 0 {$exclude_fields_sql} {$in_sql} ORDER BY field_order" );
+
+        // Bail if no fields.
+        if ( empty( $field_ids ) ) {
+            return $groups;
+        }
+
+        $field_ids = array_map( 'intval', $field_ids );
+
+        // Prime the field cache.
+        $uncached_field_ids = bp_get_non_cached_ids( $field_ids, 'bp_xprofile_fields' );
+        if ( ! empty( $uncached_field_ids ) ) {
+            $_uncached_field_ids = implode( ',', array_map( 'intval', $uncached_field_ids ) );
+            $uncached_fields = $wpdb->get_results( "SELECT * FROM {$bp->profile->table_name_fields} WHERE id IN ({$_uncached_field_ids})" );
+            foreach ( $uncached_fields as $uncached_field ) {
+                $fid = intval( $uncached_field->id );
+                wp_cache_set( $fid, $uncached_field, 'bp_xprofile_fields' );
+            }
+        }
+
+        // Pull field objects from the cache.
+        $fields = array();
+        foreach ( $field_ids as $field_id ) {
+            $fields[] = xprofile_get_field( $field_id );
+        }
 
         // Store field IDs for meta cache priming.
         $object_ids['field'] = $field_ids;
-
-        // Bail if no fields.
-        if ( empty( $fields ) ) {
-            return $groups;
-        }
 
         // Maybe fetch field data.