Changeset 10164 for trunk/tests/phpunit/testcases/xprofile/class-bp-xprofile-field.php

Timestamp:

10/02/2015 09:57:22 PM (9 years ago)

Author:

boonebgorges

Message:

Lazy-load visibility properties in BP_XProfile_Field.

Previously, populating a new BP_XProfile_Field object would result in two
queries: one to fetch the field row from the database, and one to populate the
field meta cache in order to set the 'allow_custom_visibility' and
'default_visibility' properties. It's not often the case that we need the
latter properties, which means that the cache-priming query is wasted.

This changeset addresses the shortcoming by loading the properties only when
they're requested:

• $allow_custom_visibility and $default_visibility are now protected properties of the object. This directs requests for them to the magic methods.
• Introduce __isset() and __get() to handle backward compatibility.
• Introduce public getter functions for each property.

See #6638.

File:

• trunk/tests/phpunit/testcases/xprofile/class-bp-xprofile-field.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/xprofile/class-bp-xprofile-field.php

@@ -5 +5 @@
  */
 class BP_Tests_BP_XProfile_Field_TestCases extends BP_UnitTestCase {
-    
+
     /**
      * @group xprofile_field_save
@@ -121 +121 @@
         $this->assertSame( $new_field_id, $field->id );
     }
+
+    /**
+     * @ticket BP6638
+     */
+    public function test_default_visibility_should_be_lazy_loaded() {
+        global $wpdb;
+
+        $group = $this->factory->xprofile_group->create();
+        $field = $this->factory->xprofile_field->create( array(
+            'field_group_id' => $group,
+        ) );
+
+        bp_xprofile_update_meta( $field, 'field', 'default_visibility', 'loggedin' );
+
+        // Initial setup takes just one query.
+        $num_queries = $wpdb->num_queries;
+        $field_obj = new BP_XProfile_Field( $field );
+        $num_queries++;
+
+        $this->assertSame( $num_queries, $wpdb->num_queries );
+
+        // Fetching the default_visibility should cause another query.
+        $this->assertSame( 'loggedin', $field_obj->default_visibility );
+        $num_queries++;
+
+        $this->assertSame( $num_queries, $wpdb->num_queries );
+    }
+
+    /**
+     * @ticket BP6638
+     */
+    public function test_allow_custom_visibility_should_be_lazy_loaded() {
+        global $wpdb;
+
+        $group = $this->factory->xprofile_group->create();
+        $field = $this->factory->xprofile_field->create( array(
+            'field_group_id' => $group,
+        ) );
+
+        bp_xprofile_update_meta( $field, 'field', 'allow_custom_visibility', 'disabled' );
+
+        // Initial setup takes just one query.
+        $num_queries = $wpdb->num_queries;
+        $field_obj = new BP_XProfile_Field( $field );
+        $num_queries++;
+
+        $this->assertSame( $num_queries, $wpdb->num_queries );
+
+        // Fetching the allow_custom_visibility should cause another query.
+        $this->assertSame( 'disabled', $field_obj->allow_custom_visibility );
+        $num_queries++;
+
+        $this->assertSame( $num_queries, $wpdb->num_queries );
+    }
 }