Changeset 10132

Timestamp:

09/24/2015 01:13:18 AM (10 years ago)

Author:

r-a-y

Message:

bp-legacy: Change strict cookie checks to undefined instead of null.

Fixes an issue where no default tab is selected on a BuddyPress directory
page when no cookie is set.

Props davidtcarson.

Fixes #6614 (2.3-branch).

File:

• branches/2.3/src/bp-templates/bp-legacy/js/buddypress.js (modified) (3 diffs)

branches/2.3/src/bp-templates/bp-legacy/js/buddypress.js

@@ -1809 +1809 @@
     } );
 
-    if ( null !== jq.cookie('bp-activity-filter') && jq('#activity-filter-select').length ) {
+    if ( undefined !== jq.cookie('bp-activity-filter') && jq('#activity-filter-select').length ) {
         jq('#activity-filter-select select option[value="' + jq.cookie('bp-activity-filter') + '"]').prop( 'selected', true );
     }
 
     /* Activity Tab Set */
-    if ( null !== jq.cookie('bp-activity-scope') && jq('.activity-type-tabs').length ) {
+    if ( undefined !== jq.cookie('bp-activity-scope') && jq('.activity-type-tabs').length ) {
         jq('.activity-type-tabs li').each( function() {
             jq(this).removeClass('selected');
@@ -1825 +1825 @@
 function bp_init_objects(objects) {
     jq(objects).each( function(i) {
-        if ( null !== jq.cookie('bp-' + objects[i] + '-filter') && jq('#' + objects[i] + '-order-select select').length ) {
+        if ( undefined !== jq.cookie('bp-' + objects[i] + '-filter') && jq('#' + objects[i] + '-order-select select').length ) {
             jq('#' + objects[i] + '-order-select select option[value="' + jq.cookie('bp-' + objects[i] + '-filter') + '"]').prop( 'selected', true );
         }
 
-        if ( null !== jq.cookie('bp-' + objects[i] + '-scope') && jq('div.' + objects[i]).length ) {
+        if ( undefined !== jq.cookie('bp-' + objects[i] + '-scope') && jq('div.' + objects[i]).length ) {
             jq('.item-list-tabs li').each( function() {
                 jq(this).removeClass('selected');
@@ -1958 +1958 @@
 
         /* Update the feed link */
-        if ( null !== response.feed_url ) {
+        if ( undefined !== response.feed_url ) {
             jq('.directory #subnav li.feed a, .home-page #subnav li.feed a').attr('href', response.feed_url);
         }