Changeset 10071

Timestamp:

08/27/2015 02:50:40 AM (9 years ago)

Author:

mercime

Message:

Remove duplicate IDs from xProfiles admin screen.

Duplicate id values are generated in both the fieldset and in any of the
associated form control elements in the Profile Fields admin screen. The id
value is required for all form controls to be associated with label tags
while the ‘id value for the fieldset` element on the other hand is not
used in either the Profile Fields admin CSS nor JS. Removing the id attribute
from the fieldset element fixes the issue of duplicate ids in the DOM .

Props mercime, boonebgorges, djpaul, johnjamesjacoby.
Fixes #6472.

File:

• trunk/src/bp-xprofile/bp-xprofile-admin.php (modified) (1 diff)

trunk/src/bp-xprofile/bp-xprofile-admin.php

@@ -502 +502 @@
     $field = $admin_field; ?>
 
-    <fieldset id="field_<?php echo esc_attr( $field->id ); ?>" class="sortable<?php echo ' ' . $field->type; if ( !empty( $class ) ) echo ' ' . $class; ?>">
+    <fieldset class="sortable<?php echo ' ' . $field->type; if ( !empty( $class ) ) echo ' ' . $class; ?>">
         <legend>
             <span>