Changeset 10007

Timestamp:

07/10/2015 10:17:49 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Admin: Add primary columns to our list table implementations.

The commit ensures BuddyPress's list-tables have "primary" columns, to play nicely with new WordPress 4.3.0 requirement introduced in ​[WP32722]. BuddyPress manually sets $_column_headers for horse reasons.

See #6465. For 2.3.3 (2.3 branch)

Location:

branches/2.3/src

Files:

• bp-activity/bp-activity-admin.php (modified) (2 diffs)
• bp-groups/bp-groups-admin.php (modified) (2 diffs)
• bp-members/admin/bp-members-admin-classes.php (modified) (2 diffs)

branches/2.3/src/bp-activity/bp-activity-admin.php

@@ -1198 +1198 @@
             array(),
             $this->get_sortable_columns(),
+            $this->get_default_primary_column_name(),
         );
 
@@ -1731 +1732 @@
         return $tree;
     }
+
+    /**
+     * Get name of default primary column
+     *
+     * @since BuddyPress (2.3.3)
+     * @access protected
+     *
+     * @return string
+     */
+    protected function get_default_primary_column_name() {
+        return 'author';
+    }
 }

branches/2.3/src/bp-groups/bp-groups-admin.php

@@ -1294 +1294 @@
             array(),
             $this->get_sortable_columns(),
+            $this->get_default_primary_column_name(),
         );
 
@@ -1705 +1706 @@
         return apply_filters( 'bp_groups_admin_get_group_custom_column', '', $column_name, $item );
     }
+
+    /**
+     * Get name of default primary column
+     *
+     * @since BuddyPress (2.3.3)
+     * @access protected
+     *
+     * @return string
+     */
+    protected function get_default_primary_column_name() {
+        // comment column is mapped to Group's name
+        return 'comment';
+    }
 }

branches/2.3/src/bp-members/admin/bp-members-admin-classes.php

@@ -207 +207 @@
         $style = '';
         foreach ( $this->items as $userid => $signup_object ) {
+
+            // Avoid a notice error appearing since 4.3.0
+            if ( isset( $signup_object->id ) ) {
+                $signup_object->ID = $signup_object->id;
+            }
+
             $style = ( ' class="alternate"' == $style ) ? '' : ' class="alternate"';
             echo "\n\t" . $this->single_row( $signup_object, $style );
@@ -570 +576 @@
         $style = '';
         foreach ( $this->items as $userid => $signup_object ) {
+
+            // Avoid a notice error appearing since 4.3.0
+            if ( isset( $signup_object->id ) ) {
+                $signup_object->ID = $signup_object->id;
+            }
+
             $style = ( ' class="alternate"' == $style ) ? '' : ' class="alternate"';
             echo "\n\t" . $this->single_row( $signup_object, $style );