Ticket #8558: 8558.3.patch

src/bp-groups/bp-groups-functions.php

@@ -3673 +3673 @@
         foreach ( array_keys( $registered_group_extensions ) as $group_extension_class ) {
                 $extension = new $group_extension_class;
 
-                add_action( 'bp_actions', array( &$extension, '_register' ), 8 );
-                add_action( 'admin_init', array( &$extension, '_register' ) );
+                add_action( 'bp_actions', array( $extension, '_register' ), 8 );
+                add_action( 'admin_init', array( $extension, '_register' ) );
         }
 }
 add_action( 'bp_init', 'bp_init_group_extensions', 11 );

tests/phpunit/testcases/groups/class-bp-group-extension.php

@@ -887 +887 @@
 
                 $this->assertFalse( $content === 'Widget Displayed' );
         }
+
+        /**
+         * @ticket BP8558
+         * @expectedIncorrectUsage bp_nav
+         */
+        public function test_adding_multiple_extension_classes() {
+                $old_options_nav = buddypress()->bp_options_nav;
+
+                $g = self::factory()->group->create();
+                $g_obj = groups_get_group( $g );
+
+                $e = new BPTest_Group_Extension_Enable_Nav_Item_True();
+                $e_class_name = get_class( $e );
+                $f = new BPTest_Group_Extension_Access_Anyone();
+                $f_class_name = get_class( $f );
+
+                bp_register_group_extension( $e_class_name );
+                bp_register_group_extension( $f_class_name );
+
+                $this->go_to( bp_get_group_permalink( $g_obj ) );
+
+                $this->assertTrue( isset( buddypress()->bp_options_nav[ $g_obj->slug ][ $e->slug ] ) && isset( buddypress()->bp_options_nav[ $g_obj->slug ][ $f->slug ] ) );
+
+                // Clean up
+                buddypress()->bp_options_nav = $old_options_nav;
+        }
 }