Ticket #8291: 8291.patch

src/bp-core/admin/bp-core-admin-functions.php

@@ -783 +783 @@
         $tabs['loggedout']['label'] = __( 'Logged-Out', 'buddypress' );
         $tabs['loggedout']['pages'] = bp_nav_menu_get_loggedout_pages();
 
+        // Introduced in WordPress 5.3.0
+        $is_wp_53_or_up  = function_exists( 'get_post_states' );
+        $data_items_type = '';
+        $select_all      = __( 'Select All', 'buddypress' );
+        $menu_id         = 'buddypress-menu';
+
+        if ( $is_wp_53_or_up ) {
+                $data_items_type = sprintf( 'data-items-type="posttype-%s"', esc_attr( $post_type_name ) );
+                $menu_id         = 'posttype-buddypress';
+        }
         ?>
 
-        <div id="buddypress-menu" class="posttypediv">
+        <div id="<?php echo esc_attr( $menu_id ); ?>" class="posttypediv">
                 <h4><?php _e( 'Logged-In', 'buddypress' ); ?></h4>
                 <p><?php _e( '<em>Logged-In</em> links are relative to the current user, and are not visible to visitors who are not logged in.', 'buddypress' ); ?></p>
 
@@ -815 +825 @@
                 );
                 ?>
 
-                <p class="button-controls">
-                        <span class="list-controls">
-                                <a href="
-                                <?php
-                                echo esc_url(
-                                        add_query_arg(
-                                                array(
-                                                        $post_type_name . '-tab' => 'all',
-                                                        'selectall'              => 1,
-                                                ),
-                                                remove_query_arg( $removed_args )
-                                        )
-                                );
-                                ?>
-                                #buddypress-menu" class="select-all"><?php _e( 'Select All', 'buddypress' ); ?></a>
-                        </span>
+                <?php printf( '<p class="button-controls wp-clearfix"%s>', $data_items_type ); ?>
+                        <?php if ( $is_wp_53_or_up ) : ?>
+                                <span class="list-controls hide-if-no-js">
+                                        <input type="checkbox" id="<?php echo esc_attr( $post_type_name . '-tab' ); ?>" class="select-all" />
+                                        <label for="<?php echo esc_attr( $post_type_name . '-tab' ); ?>"><?php echo esc_html( $select_all ); ?></label>
+                                </span>
+                        <?php else : ?>
+                                <span class="list-controls">
+                                        <a href="
+                                        <?php
+                                        echo esc_url(
+                                                add_query_arg(
+                                                        array(
+                                                                $post_type_name . '-tab' => 'all',
+                                                                'selectall'              => 1,
+                                                        ),
+                                                        remove_query_arg( $removed_args )
+                                                )
+                                        );
+                                        ?>
+                                        #buddypress-menu" class="select-all"><?php echo esc_html( $select_all ); ?></a>
+                                </span>
+                        <?php endif ;?>
+
                         <span class="add-to-menu">
                                 <input type="submit"
                                 <?php