Context Navigation

Ticket #8235: 8235.diff

File 8235.diff, 1.8 KB (added by audrasjb, 6 years ago)
Setttins: add screen reader text for link that opens in a new window, and a dashicon for sighted users as well (includes small CSS changes to handle dashicons in buttons)

diff --git a/src/bp-core/admin/bp-core-admin-slugs.php b/src/bp-core/admin/bp-core-admin-slugs.php
index 058605401..d6f8673ec 100644

  function bp_core_admin_slugs_options() {
                                                         <?php if ( !empty( $existing_pages[$name] ) ) : ?>
                                                                 <a href="<?php echo get_permalink( $existing_pages[$name] ); ?>" class="button-secondary" target="_bp"><?php _e( 'View', 'buddypress' ); ?></a>
+                                                                <a href="<?php echo get_permalink( $existing_pages[$name] ); ?>" class="button-secondary" target="_bp"><?php _e( 'View', 'buddypress' ); ?> <span class="dashicons dashicons-external"></span><span class="screen-reader-text"> <?php esc_html_e( '(opens in a new window)', 'buddypress' ); ?></span></a>
                                                         <?php endif; ?>

diff --git a/src/bp-core/admin/css/common-rtl.css b/src/bp-core/admin/css/common-rtl.css
index 1193224c2..19d22613d 100644

  TABLE OF CONTENTS:
         content: "\f307";
+}
+.settings_page_bp-page-settings .button-primary .dashicons, .settings_page_bp-page-settings .button-secondary .dashicons {
+        position: relative;
+        top: 3px;
+}
 #bp-admin-component-form .wp-list-table.plugins .plugin-title {
         width: 25%;
+}

diff --git a/src/bp-core/admin/css/common.css b/src/bp-core/admin/css/common.css
index b80e5dc48..47b208441 100644

  TABLE OF CONTENTS:
         content: "\f307";
+}
+.settings_page_bp-page-settings .button-primary .dashicons, .settings_page_bp-page-settings .button-secondary .dashicons {
+        position: relative;
+        top: 3px;
+}
 #bp-admin-component-form .wp-list-table.plugins .plugin-title {
         width: 25%;
+}