Skip to:
Content

BuddyPress.org

Ticket #8235: 8235.diff

File 8235.diff, 1.8 KB (added by audrasjb, 5 years ago)

Setttins: add screen reader text for link that opens in a new window, and a dashicon for sighted users as well (includes small CSS changes to handle dashicons in buttons)

  • src/bp-core/admin/bp-core-admin-slugs.php

    diff --git a/src/bp-core/admin/bp-core-admin-slugs.php b/src/bp-core/admin/bp-core-admin-slugs.php
    index 058605401..d6f8673ec 100644
    a b function bp_core_admin_slugs_options() { 
    145145
    146146                                                        <?php if ( !empty( $existing_pages[$name] ) ) : ?>
    147147
    148                                                                 <a href="<?php echo get_permalink( $existing_pages[$name] ); ?>" class="button-secondary" target="_bp"><?php _e( 'View', 'buddypress' ); ?></a>
     148                                                                <a href="<?php echo get_permalink( $existing_pages[$name] ); ?>" class="button-secondary" target="_bp"><?php _e( 'View', 'buddypress' ); ?> <span class="dashicons dashicons-external"></span><span class="screen-reader-text"> <?php esc_html_e( '(opens in a new window)', 'buddypress' ); ?></span></a>
    149149
    150150                                                        <?php endif; ?>
    151151
  • src/bp-core/admin/css/common-rtl.css

    diff --git a/src/bp-core/admin/css/common-rtl.css b/src/bp-core/admin/css/common-rtl.css
    index 1193224c2..19d22613d 100644
    a b TABLE OF CONTENTS: 
    274274        content: "\f307";
    275275}
    276276
     277.settings_page_bp-page-settings .button-primary .dashicons, .settings_page_bp-page-settings .button-secondary .dashicons {
     278        position: relative;
     279        top: 3px;
     280}
     281
    277282#bp-admin-component-form .wp-list-table.plugins .plugin-title {
    278283        width: 25%;
    279284}
  • src/bp-core/admin/css/common.css

    diff --git a/src/bp-core/admin/css/common.css b/src/bp-core/admin/css/common.css
    index b80e5dc48..47b208441 100644
    a b TABLE OF CONTENTS: 
    274274        content: "\f307";
    275275}
    276276
     277.settings_page_bp-page-settings .button-primary .dashicons, .settings_page_bp-page-settings .button-secondary .dashicons {
     278        position: relative;
     279        top: 3px;
     280}
     281
    277282#bp-admin-component-form .wp-list-table.plugins .plugin-title {
    278283        width: 25%;
    279284}