Ticket #7608: 7608.revert.02.patch

src/bp-groups/bp-groups-template.php

@@ -467 +467 @@
 }
 
 /**
- * Is the group visible to the currently logged-in user?
+ * Is the group accessible to the currently logged-in user?
+ * Despite the name of the function, it has historically checked
+ * whether a user has access to a group. 
+ * In BP 2.9, a property was added to the BP_Groups_Group class, 
+ * `is_visible`, that describes whether a user can know the group exists.
+ * If you wish to check that property, use the check: 
+ * bp_current_user_can( 'groups_see_group' ).
  *
  * @since 1.0.0
  *
@@ -485 +491 @@
                 $group =& $groups_template->group;
         }
 
-        if ( ! empty( $group->is_visible ) ) {
-                return true;
-        }
-
-        return false;
+        return bp_current_user_can( 'groups_access_group', array( 'group_id' => $group->id ) );
 }
 
 /**

src/bp-templates/bp-nouveau/buddypress/groups/single/parts/header-item-actions.php

@@ -7 +7 @@
 ?>
 <div id="item-actions" class="group-item-actions">
 
-        <?php if ( bp_group_is_visible() ) : ?>
+        <?php if ( bp_current_user_can( 'groups_access_group' ) ) : ?>
 
                 <dl class="moderators-lists">
                         <dt class="moderators-title"><?php _e( 'Group Admins', 'buddypress' ); ?></dt>

src/bp-templates/bp-nouveau/includes/groups/template-tags.php

@@ -1153 +1153 @@
 
         $bp_is_group_home = bp_is_group_home();
 
-        if ( $bp_is_group_home && ! bp_group_is_visible() ) {
+        if ( $bp_is_group_home && ! bp_current_user_can( 'groups_access_group' ) ) {
                 /**
                  * Fires before the display of the group status message.
                  *