Ticket #7477: 7477.1.diff

src/bp-groups/classes/class-bp-groups-group.php

@@ -619 +619 @@
         public static function group_exists( $slug, $table_name = false ) {
                 global $wpdb;
 
-                if ( empty( $table_name ) )
-                        $table_name = buddypress()->groups->table_name;
-
-                if ( empty( $slug ) )
+                if ( empty( $slug ) ) {
                         return false;
+                }
 
-                $query = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$table_name} WHERE slug = %s", strtolower( $slug ) ) );
+                if ( ! $table_name ) {
+                        $table_name = buddypress()->groups->table_name;
+                }
+
+                $group_exists_sql = $wpdb->prepare( "SELECT id FROM {$table_name} WHERE slug = %s", strtolower( $slug ) );
+                $cached = bp_core_get_incremented_cache( $group_exists_sql, 'bp_groups' );
+                if ( false === $cached ) {
+                        $group_id = $wpdb->get_var( $group_exists_sql );
+                        bp_core_set_incremented_cache( $group_exists_sql, 'bp_groups', $group_id );
+                } else {
+                        $group_id = $cached;
+                }
 
-                return is_numeric( $query ) ? (int) $query : $query;
+                return is_numeric( $group_id ) ? (int) $group_id : $group_id;
         }
 
         /**

tests/phpunit/testcases/groups/cache.php

@@ -259 +259 @@
                 // check if function references cache or hits the DB by comparing query count
                 $this->assertEquals( $first_query_count, $wpdb->num_queries );
         }
+
+        /**
+         * @group group_exists
+         */
+        public function test_group_exists_uses_cache() {
+                global $wpdb;
+
+                $g1 = $this->factory->group->create( array(
+                        'slug' => 'sam',
+                ) );
+
+                $group_id = BP_Groups_Group::group_exists( 'sam' );
+                $first_query_count = $wpdb->num_queries;
+                $group_id_again = BP_Groups_Group::group_exists( 'sam' );
+
+                $this->assertEquals( $first_query_count, $wpdb->num_queries );
+        }
+
+        /**
+         * @group group_exists
+         */
+        public function test_group_exists_uses_cache_no_match() {
+                global $wpdb;
+
+                $group_id = BP_Groups_Group::group_exists( 'brandywine-river' );
+                $first_query_count = $wpdb->num_queries;
+                $group_id_again = BP_Groups_Group::group_exists( 'brandywine-river' );
+
+                $this->assertEquals( $first_query_count, $wpdb->num_queries );
+        }
 }

tests/phpunit/testcases/groups/class-bp-groups-group.php

@@ -2011 +2011 @@
                 $found = wp_list_pluck( $groups['groups'], 'id' );
                 $this->assertEqualSets( array( $g1, $g4 ), $found );
         }
+
+        /**
+         * @group group_exists
+         */
+        public function test_group_exists_expected_behavior() {
+                $g1 = $this->factory->group->create( array(
+                        'slug' => 'sam',
+                ) );
+
+                $group_id = BP_Groups_Group::group_exists( 'sam' );
+
+                $this->assertEquals( $g1, $group_id );
+        }
+
+        /**
+         * @group group_exists
+         */
+        public function test_group_exists_expected_behavior_no_match() {
+                $group_id = BP_Groups_Group::group_exists( 'brandywine-river' );
+
+                $this->assertNull( $group_id );
+        }
 }
 
 /**