Ticket #7436: 7436.1.diff

src/bp-friends/classes/class-bp-friends-friendship.php

@@ -257 +257 @@
                         'per_page'          => null
                 ), 'bp_get_user_friendships' );
 
-                // First, we get all friendships that involve the user.
-                $friendship_ids = wp_cache_get( $user_id, 'bp_friends_friendships_for_user' );
-                if ( false === $friendship_ids ) {
-                        $friendship_ids = self::get_friendship_ids_for_user( $user_id );
-                        wp_cache_set( $user_id, $friendship_ids, 'bp_friends_friendships_for_user' );
+                $using_bulk_cache = apply_filters( 'bp_bulk_cache_user_friendships', true );
+
+                if ( $using_bulk_cache ) {
+                        // First, we get all friendships that involve the user.
+                        $friendship_ids = wp_cache_get( $user_id, 'bp_friends_friendships_for_user' );
+                        if ( false === $friendship_ids ) {
+                                $friendship_ids = self::get_friendship_ids_for_user( $user_id );
+                                wp_cache_set( $user_id, $friendship_ids, 'bp_friends_friendships_for_user' );
+                        }
+                } else {
+                        /*
+                        * We're not using the user bulk cache method because the site has an
+                        * unusually large number of friendships per user or something.
+                        * In this case, we build and run direct queries.
+                        */
+                        global $wpdb;
+                        $bp = buddypress();
+                        $friendships = array();
+
+                        // Build an SQL query
+                        $sql = array(
+                                'select'     => "SELECT DISTINCT id",
+                                'from'       => "{$bp->friends->table_name}",
+                                'where'      => '',
+                                'orderby'    => 'date_created',
+                                'order'      => 'DESC',
+                                'pagination' => '',
+                        );
+                        $where_conditions = array();
+
+                        // First limit all requests to refer to the passed user ID.
+                        $where_user = $wpdb->prepare( "(initiator_user_id = %d OR friend_user_id = %d)", $user_id, $user_id );
+
+                        if ( $r['initiator_user_id'] ) {
+                                $where_conditions['who_initiated'] = $wpdb->prepare( "initiator_user_id = %d", $r['initiator_user_id'] );
+                        }
+                        if ( $r['friend_user_id'] ) {
+                                $where_conditions['who_friend'] = $wpdb->prepare( "friend_user_id = %d", $r['friend_user_id'] );
+                        }
+                        if ( ! is_null( $r['is_confirmed'] ) ) {
+                                $where_conditions['is_confirmed'] = $wpdb->prepare( "is_confirmed = %d", $r['is_confirmed'] );
+                        }
+                        if ( ! is_null( $r['is_limited'] ) ) {
+                                $where_conditions['is_limited'] = $wpdb->prepare( "is_limited = %d", $r['is_limited'] );
+                        }
+
+                        $where = "WHERE {$where_user}";
+                        if ( ! empty( $where_conditions ) ) {
+                                $operator = strtoupper( $operator );
+                                if ( ! in_array( $operator, array( 'AND', 'OR', 'NOT' ), true ) ) {
+                                        $operator = 'AND';
+                                }
+                                $sql['where'] = implode( " $operator ", $where_conditions );
+                                $where .= " AND ({$sql['where']})";
+                        }
+
+                        // Sort the results on a column name.
+                        if ( ! in_array( $r['order_by'], array( 'date_created', 'id', 'initiator_user_id', 'friend_user_id' ), true ) ) {
+                                $r['order_by'] = 'date_created';
+                        }
+                        $sql['orderby'] = "ORDER BY {$r['order_by']}";
+
+                        // Set the sort direction of the results.
+                        if ( 'ASC' === strtoupper( $r['sort_order'] ) ) {
+                                $sql['order'] = 'ASC';
+                        }
+
+                        if ( $r['per_page'] && $r['page'] && $r['per_page'] != -1 ) {
+                                $sql['pagination'] = $wpdb->prepare( "LIMIT %d, %d", intval( ( $r['page'] - 1 ) * $r['per_page']), intval( $r['per_page'] ) );
+                        }
+
+                        // Warm the friends cache.
+                        $friendship_ids = $wpdb->get_col( "{$sql['select']} FROM {$sql['from']} {$where} {$sql['orderby']} {$sql['order']} {$sql['pagination']}" );
                 }
 
                 // Prime the membership cache.
@@ -305 +373 @@
                                 $friendship->{$index} = (bool) $friendship->{$index};
                         }
 
-                        // We need to support the same operators as wp_list_filter().
-                        if ( 'OR' == $operator || 'NOT' == $operator ) {
-                                $matched = 0;
+                        // Run the filters if we're using the bulk membership cache.
+                        if ( $using_bulk_cache ) {
+                                // We need to support the same operators as wp_list_filter().
+                                if ( 'OR' == $operator || 'NOT' == $operator ) {
+                                        $matched = 0;
 
-                                foreach ( $filters as $filter_name => $filter_value ) {
-                                        if ( isset( $friendship->{$filter_name} ) && $filter_value == $friendship->{$filter_name} ) {
-                                                $matched++;
+                                        foreach ( $filters as $filter_name => $filter_value ) {
+                                                if ( isset( $friendship->{$filter_name} ) && $filter_value == $friendship->{$filter_name} ) {
+                                                        $matched++;
+                                                }
                                         }
-                                }
 
-                                if ( ( 'OR' == $operator && $matched > 0 )
-                                  || ( 'NOT' == $operator && 0 == $matched ) ) {
-                                        $friendships[ $friendship->id ] = $friendship;
-                                }
+                                        if ( ( 'OR' == $operator && $matched > 0 )
+                                          || ( 'NOT' == $operator && 0 == $matched ) ) {
+                                                $friendships[ $friendship->id ] = $friendship;
+                                        }
 
-                        } else {
-                                /*
-                                 * This is the more typical 'AND' style of filter.
-                                 * If any of the filters miss, we move on.
-                                 */
-                                foreach ( $filters as $filter_name => $filter_value ) {
-                                        if ( ! isset( $friendship->{$filter_name} ) || $filter_value != $friendship->{$filter_name} ) {
-                                                continue 2;
+                                } else {
+                                        /*
+                                         * This is the more typical 'AND' style of filter.
+                                         * If any of the filters miss, we move on.
+                                         */
+                                        foreach ( $filters as $filter_name => $filter_value ) {
+                                                if ( ! isset( $friendship->{$filter_name} ) || $filter_value != $friendship->{$filter_name} ) {
+                                                        continue 2;
+                                                }
                                         }
+                                        $friendships[ $friendship->id ] = $friendship;
                                 }
+                        } else {
+                                // The sorting has already been done in the SQL query.
                                 $friendships[ $friendship->id ] = $friendship;
                         }
 
                 }
 
-                // Sort the results on a column name.
-                if ( in_array( $r['order_by'], array( 'id', 'initiator_user_id', 'friend_user_id' ) ) ) {
-                        $friendships = bp_sort_by_key( $friendships, $r['order_by'], 'num', true );
-                }
+                // Do some organization if we're using the bulk membership cache.
+                if ( $using_bulk_cache ) {
+                        // Sort the results on a column name.
+                        if ( in_array( $r['order_by'], array( 'id', 'initiator_user_id', 'friend_user_id' ) ) ) {
+                                $friendships = bp_sort_by_key( $friendships, $r['order_by'], 'num', true );
+                        }
 
-                // Adjust the sort direction of the results.
-                if ( 'ASC' === strtoupper( $r['sort_order'] ) ) {
-                        // `true` to preserve keys.
-                        $friendships = array_reverse( $friendships, true );
-                }
+                        // Adjust the sort direction of the results.
+                        if ( 'ASC' === strtoupper( $r['sort_order'] ) ) {
+                                // `true` to preserve keys.
+                                $friendships = array_reverse( $friendships, true );
+                        }
 
-                // Paginate the results.
-                if ( $r['per_page'] && $r['page'] ) {
-                        $start       = ( $r['page'] - 1 ) * ( $r['per_page'] );
-                        $friendships = array_slice( $friendships, $start, $r['per_page'] );
+                        // Paginate the results.
+                        if ( $r['per_page'] && $r['page'] ) {
+                                $start       = ( $r['page'] - 1 ) * ( $r['per_page'] );
+                                $friendships = array_slice( $friendships, $start, $r['per_page'] );
+                        }
                 }
 
                 return $friendships;