Ticket #7325: 7325-group-extension-class-anonymous-functions.diff

src/bp-groups/classes/class-bp-group-extension.php

@@ -752 +752 @@
 
                         // When we are viewing the extension display page, set the title and options title.
                         if ( bp_is_current_action( $this->slug ) ) {
+                                $name = $this->name;
                                 add_filter( 'bp_group_user_has_access',   array( $this, 'group_access_protection' ), 10, 2 );
-                                add_action( 'bp_template_content_header', create_function( '', 'echo "' . esc_attr( $this->name ) . '";' ) );
-                                add_action( 'bp_template_title',          create_function( '', 'echo "' . esc_attr( $this->name ) . '";' ) );
+                                add_action( 'bp_template_content_header', function() use ( $name ) { echo esc_attr( $name ); } );
+                                add_action( 'bp_template_title',          function() use ( $name ) { echo esc_attr( $name ); } );
                         }
                 }
@@ -1184 +1189 @@
         public function _meta_box_display_callback() {
                 $group_id = isset( $_GET['gid'] ) ? (int) $_GET['gid'] : 0;
                 $screen   = $this->screens['admin'];
-
+                $slug     = $this->slug;
                 add_meta_box(
                         $screen['slug'],
                         $screen['name'],
-                        create_function( '', 'do_action( "bp_groups_admin_meta_box_content_' . $this->slug . '", ' . $group_id . ' );' ),
+                        function() use ( $slug, $group_id ) {
+
+                                /**
+                                 * Fires as part of the add_meta_box callback.
+                                 *
+                                 * Note this is a dynamic action that relies on the current extension slug.
+                                 *
+                                 * @since 1.7.0
+                                 *
+                                 * @param int $group_id Current group ID.
+                                 */
+                                do_action( 'bp_groups_admin_meta_box_content_{$slug}', $group_id );
+                        },
                         get_current_screen()->id,
                         $screen['metabox_context'],
                         $screen['metabox_priority']