Ticket #7325: 7325-activity-anonymous-functions.diff

src/bp-activity/bp-activity-actions.php

@@ -832 +832 @@
 
         // Add "new_post_type_comment" to the whitelisted activity types, so that the activity's Akismet history is generated
         $post_type_comment_action = $activity_comment_object->action_id;
-        $comment_akismet_history = create_function( '$t', '$t[] = $post_type_comment_action; return $t;' );
+        $comment_akismet_history = function ( $activity_types ) use ( $post_type_comment_action ) {
+                $activity_types[] = $post_type_comment_action;
+
+                return $activity_types;
+        };
         add_filter( 'bp_akismet_get_activity_types', $comment_akismet_history );
 
         // Make sure the activity change won't edit the comment if sync is on

src/bp-activity/bp-activity-functions.php

@@ -3675 +3675 @@
 function bp_dtheme_embed_read_more( $activity ) {
         buddypress()->activity->read_more_id = $activity->id;
 
-        add_filter( 'embed_post_id',         create_function( '', 'return buddypress()->activity->read_more_id;' ) );
+        add_filter( 'embed_post_id',         function() { return buddypress()->activity->read_more_id; } );
         add_filter( 'bp_embed_get_cache',    'bp_embed_activity_cache',      10, 3 );
         add_action( 'bp_embed_update_cache', 'bp_embed_activity_save_cache', 10, 3 );
 }

src/bp-activity/classes/class-bp-activity-list-table.php

@@ -171 +171 @@
                         $activities['total']      = count( $activities['activities'] );
 
                         // Sort the array by the activity object's date_recorded value.
-                        usort( $activities['activities'], create_function( '$a, $b', 'return $a->date_recorded > $b->date_recorded;' ) );
+                        usort( $activities['activities'], function( $a, $b ) { return $a->date_recorded > $b->date_recorded; } );
                 }
 
                 // The bp_activity_get function returns an array of objects; cast these to arrays for WP_List_Table.