Ticket #7248: 7248.diff

src/bp-core/classes/class-bp-user-query.php

@@ -364 +364 @@
                 // 'include' - User ids to include in the results.
                 $include     = false !== $include ? wp_parse_id_list( $include ) : array();
                 $include_ids = $this->get_include_ids( $include );
-                if ( ! empty( $include_ids ) ) {
+
+                // An array containing nothing but 0 should always fail.
+                if ( 1 === count( $include_ids ) && 0 == reset( $include_ids ) ) {
+                        $sql['where'][] = $this->no_results['where'];
+                } elseif ( ! empty( $include_ids ) ) {
                         $include_ids    = implode( ',', wp_parse_id_list( $include_ids ) );
                         $sql['where'][] = "u.{$this->uid_name} IN ({$include_ids})";
                 }

tests/phpunit/testcases/core/class-bp-user-query.php

@@ -67 +67 @@
         }
 
         /**
+         * @ticket BP7248
+         */
+        public function test_include_array_contaning_only_0_should_result_in_no_results_query() {
+                $q = new BP_User_Query( array(
+                        'include' => array( 0 ),
+                ) );
+
+                $this->assertContains( '0 = 1', $q->uid_clauses['where'] );
+        }
+
+        /**
+         * @ticket BP7248
+         */
+        public function test_include_array_contaning_0_but_also_real_IDs_should_not_result_in_no_results_query() {
+                $q = new BP_User_Query( array(
+                        'include' => array( 0, 1 ),
+                ) );
+
+                $this->assertNotContains( '0 = 1', $q->uid_clauses['where'] );
+        }
+
+        /**
          * @group user_ids
          */
         public function test_bp_user_query_user_ids_with_invalid_user_id() {