Ticket #7226: 7226-02.patch

src/bp-core/classes/class-bp-button.php

@@ -33 +33 @@
  *                                          Default: ''.
  *     @type string      $wrapper_class     Optional. DOM class of the button wrapper
  *                                          element. Default: ''.
+ *     @type string      $element           Optional. The type of element to use e.g 'anchor', 'button'
+ *                                          Default: 'anchor'.
+ *     @type string      $button_type       Optional. Set the button type i.e like input types
+ *                                          Defaults to 'button' [type="button"] can be 'submit' [type="submit"]
+ *     @type string      $button_name       Optional: Button 'name' value - if type == 'submit'.
+ *     @type string      $button_value      Optional: Button 'value' value - if type == 'submit'.
  *     @type string      $link_href         Optional. Destination link of the button.
  *                                          Default: ''.
+ *     @type string      $data_attr         Optional. Allow a data attributte to be set. e.g 'data-bp-buttons=""'
+ *                                          Default: ''.
  *     @type string      $link_class        Optional. DOM class of the button. Default: ''.
  *     @type string      $link_id           Optional. DOM ID of the button. Default: ''.
  *     @type string      $link_rel          Optional. DOM 'rel' attribute of the button.
@@ -103 +111 @@
         /** Button ****************************************************************/
 
         /**
+        * The node element type type i.e. a true '<button>' element or '<a>' anchor:
+        * 'button', 'anchor'
+        *
+        * @var string
+        */
+        public $element = 'anchor';
+
+        /**
+        * The button elements type i.e. 'submit', 'button'.
+        *
+        *
+        * @var string
+        */
+        public $button_type = 'button';
+
+        /**
+        * The button elements name attr i.e. 'name=""'.
+        *
+        *
+        * @var string
+        */
+        public $button_name = '';
+
+        /**
+        * The button elements value attr i.e. 'value=""'.
+        *
+        *
+        * @var string
+        */
+        public $button_value = '';
+
+
+        /**
          * The destination link of the button.
          *
          * @var string
@@ -138 +179 @@
         public $link_title = '';
 
         /**
+         * A data attribute.
+         *
+         * @var string
+         */
+        public $data_attr = '';
+
+        /**
          * The contents of the button link.
          *
          * @var string
@@ -223 +271 @@
                         $before = $after = '';
                 }
 
-                // Link properties.
+
+                // Link/Button  properties.
+                //if ( !empty( $r['element']    ) ) $this->element    =
+                if ( !empty( $r['element_type'] )  && 'button' == $r['element'] ) $this->element_type = ' type="' . $r['element_type'] . '"';
+                if ( !empty( $r['button_name']  )  && 'button' == $r['element_type'] && 'submit' == $r['button_type'] ) $this->button_name = ' type="' . $r['button_name'] . '"';
+                if ( !empty( $r['button_value'] )  && 'button' == $r['element_type'] && 'submit' == $r['button_type'] ) $this->button_value = ' type="' . $r['button_value'] . '"';
                 if ( !empty( $r['link_id']    ) ) $this->link_id    = ' id="' .    $r['link_id']    . '"';
-                if ( !empty( $r['link_href']  ) ) $this->link_href  = ' href="' .  $r['link_href']  . '"';
+                // No href if we're a button please!
+                if ( !empty( $r['link_href'] && 'button' !== $r['element'] ) ) $this->link_href  = ' href="' .  $r['link_href']  . '"';
                 if ( !empty( $r['link_title'] ) ) $this->link_title = ' title="' . $r['link_title'] . '"';
                 if ( !empty( $r['link_rel']   ) ) $this->link_rel   = ' rel="' .   $r['link_rel']   . '"';
                 if ( !empty( $r['link_class'] ) ) $this->link_class = ' class="' . $r['link_class'] . '"';
-                if ( !empty( $r['link_text']  ) ) $this->link_text  =              $r['link_text'];
+                if ( !empty( $r['data_attr']  ) ) $this->data_attr  = ' ' . $r['data_attr'] ;
+                if ( !empty( $r['link_text']  ) ) $this->link_text  =   $r['link_text'];
 
+                // The element tag: e.g '<a', '<button'
+
+                if ( 'button' == $r['element'] ) {
+                        $before_element = '<button ' . $this->element_type ;
+                        $after_element  = '</button>';
+                } else {
+                        $before_element = '<a ';
+                        $after_element  = '</a>';
+                }
+
                 // Build the button.
-                $this->contents = $before . '<a'. $this->link_href . $this->link_title . $this->link_id . $this->link_rel . $this->link_class . '>' . $this->link_text . '</a>' . $after;
+                $this->contents = $before . $before_element . $this->link_href . $this->link_title . $this->link_id . $this->link_rel  . $this->button_name . $this->button_value . $this->data_attr . $this->link_class . '>' . $this->link_text . $after_element . $after;
 
                 /**
                  * Filters the button based on class parameters.
@@ -246 +311 @@
                  * @param BP_Button $this     Current BP_Button instance.
                  * @param string    $before   HTML appended before the actual button.
                  * @param string    $after    HTML appended after the actual button.
+                 * @param string    $before_element  Actual items opening element.
+                 * @param string    $after_element   Actual items closing element t& tag .
                  */
-                $this->contents = apply_filters( 'bp_button_' . $this->component . '_' . $this->id, $this->contents, $this, $before, $after );
+                $this->contents = apply_filters( 'bp_button_' . $this->component . '_' . $this->id, $this->contents, $this, $before, $after, $before_element, $after_element );
         }
 
         /**