Ticket #7225: 7225.02.patch

src/bp-members/bp-members-functions.php

@@ -2747 +2747 @@
         $types = wp_cache_get( $user_id, 'bp_member_member_type' );
 
         if ( false === $types ) {
-                $types = bp_get_object_terms( $user_id, 'bp_member_type' );
+                $raw_types = bp_get_object_terms( $user_id, 'bp_member_type' );
+
+                if ( ! is_wp_error( $raw_types ) ) {
+                        $types =  array();
+
+                        // Only include currently registered group types.
+                        foreach ( $raw_types as $mtype ) {
+                                if ( bp_get_member_type_object( $mtype->name ) ) {
+                                        $types[] = $mtype->name;
+                                }
+                        }
 
-                if ( ! is_wp_error( $types ) ) {
-                        $types = wp_list_pluck( $types, 'name' );
                         wp_cache_set( $user_id, $types, 'bp_member_member_type' );
                 }
         }

tests/phpunit/testcases/members/types.php

@@ -392 +392 @@
                 $types = bp_get_member_type( $u1, false );
                 $this->assertEqualSets( array( 'bar', 'foo' ), $types );
         }
+
+        public function test_bp_get_member_type_should_not_return_unregistered_types() {
+                $u1 = $this->factory->user->create();
+                bp_register_member_type( 'foo' );
+                bp_set_member_type( $u1, 'foo' );
+
+                // Directly set a type that hasn't been registered.
+                bp_set_object_terms( $u1, 'ugh', 'bp_member_type', true );
+
+                $type = bp_get_member_type( $u1, false );
+                $this->assertEquals( array( 'foo' ), $type );
+        }
 }