Ticket #6612: 6612.02.patch

src/bp-core/bp-core-avatars.php

@@ -991 +991 @@
         $name_parts = pathinfo( $name );
         $name = trim( substr( $name, 0, - ( 1 + strlen( $name_parts['extension'] ) ) ) );
 
-        if ( 'user' === $bp_params['object'] ) {
-                do_action( 'xprofile_avatar_uploaded' );
-        }
-
         // Finally return the avatar to the editor
         bp_attachments_json_response( true, $is_html4, array(
                 'name'      => $name,
@@ -1057 +1053 @@
                 // Crop to default values
                 $crop_args = array( 'item_id' => $item_id, 'original_file' => $avatar_to_crop, 'crop_x' => 0, 'crop_y' => 0 );
 
-                /**
-                 * Fires if the new avatar was successfully captured.
-                 *
-                 * @since 2.3.0
-                 */
-                do_action( 'xprofile_avatar_uploaded' );
-
                 return bp_core_avatar_handle_crop( $crop_args );
         } else {
                 return false;
@@ -1200 +1189 @@
                                 'item_id'       => $avatar_data['item_id'],
                         );
 
-                        do_action( 'xprofile_screen_change_avatar' );
+                        /**
+                         * Fires if the new avatar was successfully captured.
+                         *
+                         * @since 1.1.0 Used to inform the avatar was successfully cropped
+                         * @since 2.3.4 Add a new parameter to inform about the way the avatar was set.
+                         *              eg: 'crop' or 'camera'
+                         *              Move the action at the right place, once the avatar is set
+                         *
+                         * @param string $type Inform about the way the avatar was set ('camera')
+                         */
+                        do_action( 'xprofile_avatar_uploaded', $avatar_data['type'] );
 
                         wp_send_json_success( $return );
                 }
@@ -1245 +1244 @@
                 );
 
                 if ( 'user' === $avatar_data['object'] ) {
-                        do_action( 'xprofile_screen_change_avatar' );
+                        /**
+                         * Fires if the new avatar was successfully cropped.
+                         *
+                         * @since 1.1.0 Used to inform the avatar was successfully cropped
+                         * @since 2.3.4 Add a new parameter to inform about the way the avatar was set.
+                         *              eg: 'crop' or 'camera'
+                         *              Move the action at the right place, once the avatar is set
+                         *
+                         * @param string $type Inform about the way the avatar was set ('crop')
+                         */
+                        do_action( 'xprofile_avatar_uploaded', $avatar_data['type'] );
                 }
 
                 wp_send_json_success( $return );

src/bp-xprofile/bp-xprofile-screens.php

@@ -266 +266 @@
                         /**
                          * Fires right before the redirect, after processing a new avatar.
                          *
-                         * @since BuddyPress (1.1.0)
+                         * @since 1.1.0
+                         * @since 2.3.4 Add a new parameter to inform about the way the avatar was set.
+                         *              eg: 'crop' or 'camera'
+                         *
+                         * @param string $value Inform about the way the avatar was set ('crop')
                          */
-                        do_action( 'xprofile_avatar_uploaded' );
+                        do_action( 'xprofile_avatar_uploaded', 'crop' );
                         bp_core_add_message( __( 'Your new profile photo was uploaded successfully.', 'buddypress' ) );
                         bp_core_redirect( bp_displayed_user_domain() );
                 }