Ticket #6388: 6388.04.patch

src/bp-core/bp-core-template.php

@@ -2477 +2477 @@
  * @return bool True if the current page is a single group's home page.
  */
 function bp_is_group_home() {
+        $retval = false;
+
         if ( bp_is_single_item() && bp_is_groups_component() && ( ! bp_current_action() || bp_is_current_action( 'home' ) ) ) {
-                return true;
+                $retval = true;
         }
 
-        return false;
+        // Get BuddyPress instance
+        $bp = buddypress();
+
+        /**
+         * Since 2.4.0 The group home is not necessarly the activity page, this part
+         * is making sure outdated templates will still be able to post activities
+         * if the group has a custom front template.
+         */
+        if ( isset( $bp->groups->is_activity ) && true === $bp->groups->is_activity ) {
+                $retval = true;
+
+                // Reset the backcompat global
+                unset( $bp->groups->is_activity );
+        }
+
+        return $retval;
 }
 
 /**
@@ -2534 +2551 @@
  * @return True if the current page is a group's activity page.
  */
 function bp_is_group_activity() {
-        return (bool) ( bp_is_single_item() && bp_is_groups_component() && bp_is_current_action( 'activity' ) );
+        $retval = false;
+
+        if ( bp_is_single_item() && bp_is_groups_component() && bp_is_current_action( 'activity' ) ) {
+                $retval = true;
+        }
+
+        if ( bp_is_group_home() && bp_is_active( 'activity' ) && ! bp_is_group_custom_front() ) {
+                $retval = true;
+        }
+
+        return $retval;
 }
 
 /**
@@ -2567 +2594 @@
  * @return bool True if the current page is part of a group's Members page.
  */
 function bp_is_group_members() {
-        return (bool) ( bp_is_single_item() && bp_is_groups_component() && bp_is_current_action( 'members' ) );
+        $retval = false;
+
+        if ( bp_is_single_item() && bp_is_groups_component() && bp_is_current_action( 'members' ) ) {
+                $retval = true;
+        }
+
+        if ( bp_is_group_home() && ! bp_is_active( 'activity' ) && ! bp_is_group_custom_front() ) {
+                $retval = true;
+        }
+
+        return $retval;
 }
 
 /**
@@ -2615 +2652 @@
 }
 
 /**
+ * Is the current group page a custom front?
+ *
+ * @since 2.4.0
+ *
+ * @return bool True if the current group page is a custom front.
+ */
+function bp_is_group_custom_front() {
+        $bp = buddypress();
+        return (bool) bp_is_group_home() && ! empty( $bp->groups->current_group->front_template );
+}
+
+/**
  * Is the current page the Create a Blog page?
  *
  * Eg http://example.com/sites/create/.

src/bp-groups/bp-groups-activity.php

@@ -577 +577 @@
 add_action( 'groups_leave_group',   'bp_groups_leave_group_delete_recent_activity', 10, 2 );
 add_action( 'groups_remove_member', 'bp_groups_leave_group_delete_recent_activity', 10, 2 );
 add_action( 'groups_ban_member',    'bp_groups_leave_group_delete_recent_activity', 10, 2 );
+
+/**
+ * Back compatibility for outdated templates using a custom front.php template
+ *
+ * @since  2.4.0
+ *
+ * @param  string $bp_version The current BuddyPress version
+ */
+function bp_groups_backcompat_is_group_activity( $bp_version = '' ) {
+        // The template is up to date :)
+        if ( $bp_version === '2.4.0' ) {
+                return;
+        }
+
+        /**
+         * Outdated templates are not using the bp_is_group_activity()
+         * conditional tag, but are still using bp_is_group_home().
+         *
+         * If a custom front template is found, the activity page won't be at
+         * the home level. So we need to use a global to inform bp_is_group_home()
+         * it should be true to let group members post activities within the
+         * group's activity page.
+         */
+        if ( bp_is_group_activity() && ! bp_is_group_home() ) {
+                buddypress()->groups->is_activity = true;
+
+                // Inform theme developers
+                _doing_it_wrong( 'activity/post-form.php', __( "The activity post form template is outdated, please make sure to use bp_is_group_activity() instead of bp_is_group_home().", 'buddypress' ), 'BP 2.4.0' );
+        }
+}
+add_action( 'bp_before_activity_post_form', 'bp_groups_backcompat_is_group_activity', 10, 1 );

src/bp-groups/bp-groups-loader.php

@@ -251 +251 @@
                                 $this->current_group->user_has_access = true;
                         }
 
+                        // Check once if the current group has a custom front template
+                        $this->current_group->front_template = bp_groups_get_front_template( $this->current_group );
+
                 // Set current_group to 0 to prevent debug errors
                 } else {
                         $this->current_group = 0;
@@ -364 +367 @@
 
                 $bp = buddypress();
 
+                // If the activity component is not active and the current group has no custom front, members are displayed in the home nav
+                if ( 'members' === $this->default_extension && ! bp_is_active( 'activity' ) && ! $this->current_group->front_template ) {
+                        $this->default_extension = 'home';
+                }
+
                 if ( ! bp_current_action() ) {
                         $bp->current_action = $this->default_extension;
                 }
@@ -520 +528 @@
                                 );
                         }
 
-                        $sub_nav[] = array(
-                                'name'            => sprintf( _x( 'Members <span>%s</span>', 'My Group screen nav', 'buddypress' ), number_format( $this->current_group->total_member_count ) ),
-                                'slug'            => 'members',
-                                'parent_url'      => $group_link,
-                                'parent_slug'     => $this->current_group->slug,
-                                'screen_function' => 'groups_screen_group_members',
-                                'position'        => 60,
-                                'user_has_access' => $this->current_group->user_has_access,
-                                'item_css_id'     => 'members',
-                                'no_access_url'   => $group_link,
-                        );
+                        if ( $this->current_group->front_template || bp_is_active( 'activity' ) ) {
+                                /**
+                                 * If the theme is using a custom front, create activity subnav.
+                                 */
+                                if ( $this->current_group->front_template && bp_is_active( 'activity' ) ) {
+                                        $sub_nav[] = array(
+                                                'name'            => _x( 'Activity', 'My Group screen nav', 'buddypress' ),
+                                                'slug'            => 'activity',
+                                                'parent_url'      => $group_link,
+                                                'parent_slug'     => $this->current_group->slug,
+                                                'screen_function' => 'groups_screen_group_activity',
+                                                'position'        => 11,
+                                                'user_has_access' => $this->current_group->user_has_access,
+                                                'item_css_id'     => 'activity',
+                                                'no_access_url'   => $group_link,
+                                        );
+                                }
+
+                                /**
+                                 * Only add the members subnav if it's not the home's nav
+                                 */
+                                $sub_nav[] = array(
+                                        'name'            => sprintf( _x( 'Members <span>%s</span>', 'My Group screen nav', 'buddypress' ), number_format( $this->current_group->total_member_count ) ),
+                                        'slug'            => 'members',
+                                        'parent_url'      => $group_link,
+                                        'parent_slug'     => $this->current_group->slug,
+                                        'screen_function' => 'groups_screen_group_members',
+                                        'position'        => 60,
+                                        'user_has_access' => $this->current_group->user_has_access,
+                                        'item_css_id'     => 'members',
+                                        'no_access_url'   => $group_link,
+                                );
+                        }
 
                         if ( bp_is_active( 'friends' ) && bp_groups_user_can_send_invites() ) {
                                 $sub_nav[] = array(

src/bp-groups/bp-groups-screens.php

@@ -741 +741 @@
 }
 
 /**
+ * Handle the loading of a single group's activity.
+ *
+ * @since 2.4.0
+ */
+function groups_screen_group_activity() {
+
+        if ( ! bp_is_single_item() ) {
+                return false;
+        }
+
+        /**
+         * Fires before the loading of a single group's activity page.
+         *
+         * @since 2.4.0
+         */
+        do_action( 'groups_screen_group_activity' );
+
+        /**
+         * Filters the template to load for a single group's activity page.
+         *
+         * @since 2.4.0
+         *
+         * @param string $value Path to a single group's template to load.
+         */
+        bp_core_load_template( apply_filters( 'groups_screen_group_activity', 'groups/single/activity' ) );
+}
+
+/**
  * Handle the display of a single group activity item.
  */
 function groups_screen_group_activity_permalink() {

src/bp-groups/bp-groups-template.php

@@ -4329 +4329 @@
         }
 
 /**
+ * Output the contents of the current group's home page.
+ *
+ * You should only use this when on a single group page.
+ *
+ * @since 2.4.0
+ */
+function bp_groups_front_template_part() {
+        $located = bp_groups_get_front_template();
+
+        if ( false !== $located ) {
+                $slug = str_replace( '.php', '', $located );
+
+                /**
+                 * Let plugins adding an action to bp_get_template_part get it from here
+                 *
+                 * @param string $slug Template part slug requested.
+                 * @param string $name Template part name requested.
+                 */
+                do_action( 'get_template_part_' . $slug, $slug, false );
+
+                load_template( $located, true );
+
+        } else if ( bp_is_active( 'activity' ) ) {
+                bp_get_template_part( 'groups/single/activity' );
+
+        } else if ( bp_is_active( 'members'  ) ) {
+                bp_groups_members_template_part();
+        }
+
+        return $located;
+}
+
+/**
+ * Locate a custom group front template if it exists.
+ *
+ * @since 2.4.0
+ *
+ * @param  BP_Groups_Group|null $group Optional. Falls back to current group if not passed.
+ * @return string|bool                 Path to front template on success; boolean false on failure.
+ */
+function bp_groups_get_front_template( $group = null ) {
+        if ( ! is_a( $group, 'BP_Groups_Group' ) ) {
+                $group = groups_get_current_group();
+        }
+
+        if ( ! isset( $group->id ) ) {
+                return false;
+        }
+
+        if ( isset( $group->front_template ) ) {
+                return $group->front_template;
+        }
+
+        $template_names = apply_filters( 'bp_groups_get_front_template', array(
+                'groups/single/front-id-'     . sanitize_file_name( $group->id )     . '.php',
+                'groups/single/front-slug-'   . sanitize_file_name( $group->slug )   . '.php',
+                'groups/single/front-status-' . sanitize_file_name( $group->status ) . '.php',
+                'groups/single/front.php'
+        ) );
+
+        return bp_locate_template( $template_names, false, true );
+}
+
+/**
  * Output the Group members template
  *
  * @since 2.0.0

src/bp-templates/bp-legacy/buddypress/activity/post-form.php

@@ -16 +16 @@
          * Fires before the activity post form.
          *
          * @since 1.2.0
+         * @since 2.4.0 Include a new parameter to hold the BuddyPress version
+         *              when the template has evolved.
+         *
+         * Please, make sure to keep the '2.4.0' argument of this hook, in your
+         * custom template
          */
-        do_action( 'bp_before_activity_post_form' ); ?>
+        do_action( 'bp_before_activity_post_form', '2.4.0' ); ?>
 
         <div id="whats-new-avatar">
                 <a href="<?php echo bp_loggedin_user_domain(); ?>">
@@ -66 +71 @@
                                 </div>
                                 <input type="hidden" id="whats-new-post-object" name="whats-new-post-object" value="groups" />
 
-                        <?php elseif ( bp_is_group_home() ) : ?>
+                        <?php elseif ( bp_is_group_activity() ) : ?>
 
                                 <input type="hidden" id="whats-new-post-object" name="whats-new-post-object" value="groups" />
                                 <input type="hidden" id="whats-new-post-in" name="whats-new-post-in" value="<?php bp_group_id(); ?>" />

src/bp-templates/bp-legacy/buddypress/groups/single/home.php

@@ -59 +59 @@
 
                                 if ( bp_group_is_visible() ) {
 
-                                        // Use custom front if one exists
-                                        $custom_front = bp_locate_template( array( 'groups/single/front.php' ), false, true );
-                                        if     ( ! empty( $custom_front   ) ) : load_template( $custom_front, true );
-
-                                        // Default to activity
-                                        elseif ( bp_is_active( 'activity' ) ) : bp_get_template_part( 'groups/single/activity' );
-
-                                        // Otherwise show members
-                                        elseif ( bp_is_active( 'members'  ) ) : bp_groups_members_template_part();
-
-                                        endif;
+                                        // Load appropriate front template
+                                        bp_groups_front_template_part();
 
                                 } else {