Ticket #6210: 6210-bp_get_user_groups_alt-03192019.diff

src/bp-groups/bp-groups-cache.php

@@ -254 +254 @@
 add_action( 'groups_member_before_save', 'bp_groups_clear_user_group_cache_on_membership_save' );
 add_action( 'groups_member_before_remove', 'bp_groups_clear_user_group_cache_on_membership_save' );
 
+/**
+ * Clear caches on saving a group invitation or request.
+ * The save action is called when inserting a new record or using the save() method
+ * to update an existing record.
+ *
+ * @since 5.0.0
+ *
+ * @param BP_Invitation object $invitation Characteristics of the invitation just saved.
+ */
+function bp_groups_clear_user_group_cache_on_invitation_save( BP_Invitation $invitation ) {
+        if ( sanitize_key( 'BP_Groups_Invitation_Manager' ) !== $invitation->class ) {
+                return;
+        }
+
+        wp_cache_delete( $invitation->id, 'bp_groups_invitations_as_memberships' );
+}
+add_action( 'bp_invitation_after_save', 'bp_groups_clear_user_group_cache_on_invitation_save', 10, 2 );
+
+/**
+ * Clear caches on invitation deletion or update.
+ * This also catches changes like sending an invite or marking one as accepted.
+ *
+ * @since 5.0.0
+ *
+ * @param array $args Associative array of columns/values describing invitations about to be deleted.
+ */
+function bp_groups_clear_user_group_cache_on_invitation_change( $args ) {
+        // Will the delete request act on invitations?
+        if ( empty( $args['class'] ) || 'BP_Groups_Invitation_Manager' !== $args['class'] ) {
+                return;
+        }
+
+        $args['fields' ] = 'ids';
+        $affected_invitation_ids = groups_get_invites( $args );
+        foreach ( $affected_invitation_ids as $invitation_id ) {
+                wp_cache_delete( $invitation_id, 'bp_groups_invitations_as_memberships' );
+        }
+}
+add_action( 'bp_invitation_before_delete', 'bp_groups_clear_user_group_cache_on_invitation_change' );
+add_action( 'bp_invitation_before_update', 'bp_groups_clear_user_group_cache_on_invitation_change' );
+
 /**
  * Clear group memberships cache on miscellaneous actions not covered by the 'after_save' hook.
  *

src/bp-groups/bp-groups-functions.php

@@ -949 +949 @@
 
         $user_id = intval( $user_id );
 
+        // Standard memberships
         $membership_ids = wp_cache_get( $user_id, 'bp_groups_memberships_for_user' );
         if ( false === $membership_ids ) {
                 $membership_ids = BP_Groups_Member::get_membership_ids_for_user( $user_id );
@@ -965 +966 @@
                 }
         }
 
+        // Prime the invitations- and requests-as-memberships cache
+        $invitation_ids = array();
+        if ( true !== $r['is_confirmed'] || false !== $r['invite_sent'] ) {
+                $invitation_ids = groups_get_invites( array(
+                        'user_id'     => $user_id,
+                        'invite_sent' => 'all',
+                        'type'        => 'all',
+                        'fields'      => 'ids'
+                ) );
+
+                // Prime the invitations cache.
+                $uncached_invitation_ids = bp_get_non_cached_ids( $invitation_ids, 'bp_groups_invitations_as_memberships' );
+
+                $uncached_invitations = groups_get_invites( array(
+                        'ids'         => $uncached_invitation_ids,
+                        'invite_sent' => 'all',
+                        'type'        => 'all'
+                ) );
+                foreach ( $uncached_invitations as $uncached_invitation ) {
+                        // Reshape the result as a membership db entry.
+                        $invitation = new StdClass;
+                        $invitation->id            = $uncached_invitation->id;
+                        $invitation->group_id      = $uncached_invitation->item_id;
+                        $invitation->user_id       = $uncached_invitation->user_id;
+                        $invitation->inviter_id    = $uncached_invitation->inviter_id;
+                        $invitation->is_admin      = false;
+                        $invitation->is_mod            = false;
+                        $invitation->user_title    = '';
+                        $invitation->date_modified = $uncached_invitation->date_modified;
+                        $invitation->comments      = $uncached_invitation->content;
+                        $invitation->is_confirmed  = false;
+                        $invitation->is_banned     = false;
+                        $invitation->invite_sent   = $uncached_invitation->invite_sent;
+                        wp_cache_set( $uncached_invitation->id, $invitation, 'bp_groups_invitations_as_memberships' );
+                }
+
+        }
+
+
         // Assemble filter array for use in `wp_list_filter()`.
         $filters = wp_array_slice_assoc( $r, array( 'is_confirmed', 'is_banned', 'is_admin', 'is_mod', 'invite_sent' ) );
         foreach ( $filters as $filter_name => $filter_value ) {
@@ -1006 +1046 @@
                 $groups[ $group_id ] = $membership;
         }
 
+        // Populate group invitations array from cache, and normalize.
+        foreach ( $invitation_ids as $invitation_id ) {
+                $invitation = wp_cache_get( $invitation_id, 'bp_groups_invitations_as_memberships' );
+
+                // Sanity check.
+                if ( ! isset( $invitation->group_id ) ) {
+                        continue;
+                }
+
+                // Integer values.
+                foreach ( $int_keys as $index ) {
+                        $invitation->{$index} = intval( $invitation->{$index} );
+                }
+
+                // Boolean values.
+                foreach ( $bool_keys as $index ) {
+                        $invitation->{$index} = (bool) $invitation->{$index};
+                }
+
+                foreach ( $filters as $filter_name => $filter_value ) {
+                        if ( ! isset( $invitation->{$filter_name} ) || $filter_value != $invitation->{$filter_name} ) {
+                                continue 2;
+                        }
+                }
+
+                $group_id = (int) $invitation->group_id;
+
+                $groups[ $group_id ] = $invitation;
+        }
+
         // By default, results are ordered by membership id.
         if ( 'group_id' === $r['orderby'] ) {
                 ksort( $groups );