Ticket #5691: 5691.patch

src/bp-xprofile/admin/js/admin.js

@@ -61 +61 @@
         document.getElementById(forWhat + '_option_number').value = theId;
 }
 
-function show_options(forWhat) {
-        document.getElementById( 'radio'          ).style.display = 'none';
-        document.getElementById( 'selectbox'      ).style.display = 'none';
-        document.getElementById( 'multiselectbox' ).style.display = 'none';
-        document.getElementById( 'checkbox'       ).style.display = 'none';
-
-        if ( forWhat === 'radio' ) {
-                document.getElementById( 'radio' ).style.display = '';
+/**
+ * Hide all "options" sections, and show the options section for the forWhat type.
+ */
+function show_options( forWhat ) {
+        for ( var i = 0; i < XProfileAdmin.supports_options_field_types.length; i++ ) {
+                document.getElementById( XProfileAdmin.supports_options_field_types[i] ).style.display = 'none';
         }
 
-        if ( forWhat === 'selectbox' ) {
-                document.getElementById( 'selectbox' ).style.display = '';
-        }
-
-        if ( forWhat === 'multiselectbox' ) {
-                document.getElementById( 'multiselectbox' ).style.display = '';
-        }
-
-        if ( forWhat === 'checkbox' ) {
-                document.getElementById( 'checkbox' ).style.display = '';
+        if ( XProfileAdmin.supports_options_field_types.indexOf( forWhat ) >= 0 ) {
+                document.getElementById( forWhat ).style.display = '';
         }
 }
 
@@ -124 +114 @@
 
         // Set focus in Field Title, if we're on the right page
         jQuery( '#bp-xprofile-add-field #title' ).focus();
-        
+
         // Set up deleting options ajax
         jQuery( 'a.ajax-option-delete' ).on( 'click', function() {
                 var theId = this.id.split( '-' );

src/bp-xprofile/bp-xprofile-cssjs.php

@@ -39 +39 @@
 
                 $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
                 wp_enqueue_script( 'xprofile-admin-js', buddypress()->plugin_url . "bp-xprofile/admin/js/admin{$min}.js", array( 'jquery', 'jquery-ui-sortable' ), bp_get_version() );
+
+                // Localize strings.
+                // supports_options_field_types is a dynamic list of field
+                // types that support options, for use in showing/hiding the
+                // "please enter options for this field" section
+                $strings = array(
+                        'supports_options_field_types' => array(),
+                );
+
+                foreach ( bp_xprofile_get_field_types() as $field_type => $field_type_class ) {
+                        $field = new $field_type_class();
+                        if ( $field->supports_options ) {
+                                $strings['supports_options_field_types'][] = $field_type;
+                        }
+                }
+
+                wp_localize_script( 'xprofile-admin-js', 'XProfileAdmin', $strings );
         }
 }
 add_action( 'admin_enqueue_scripts', 'xprofile_add_admin_js', 1 );