Ticket #5513: bulk_notifications_management.3.diff

src/bp-notifications/bp-notifications-template.php

@@ -1057 +1057 @@
  */
 function bp_notifications_bulk_management_dropdown() {
         ?>
+        <label class="bp-screen-reader-text" for="notification-select"><?php _e( 'Bulk Actions', 'buddypress' ); ?></label>
         <select name="notification_bulk_action" id="notification-select">
                 <option value="" selected="selected"><?php _e( 'Bulk Actions', 'buddypress' ); ?></option>
 

src/bp-templates/bp-legacy/buddypress/members/single/notifications/notifications-loop.php

@@ -3 +3 @@
                 <thead>
                         <tr>
                                 <th class="icon"></th>
-                                <th><label for="select-all-notifications"><?php _e( 'Select all', 'buddypress' ); ?></label><input id="select-all-notifications" type="checkbox"></th>
+                                <th><label class="bp-screen-reader-text" for="select-all-notifications"><?php _e( 'Select all', 'buddypress' ); ?></label><input id="select-all-notifications" type="checkbox"></th>
                                 <th class="title"><?php _e( 'Notification', 'buddypress' ); ?></th>
                                 <th class="date"><?php _e( 'Date Received', 'buddypress' ); ?></th>
                                 <th class="actions"><?php _e( 'Actions',    'buddypress' ); ?></th>

src/bp-templates/bp-legacy/css/buddypress.css

@@ -731 +731 @@
 #buddypress .standard-form #blog-details-section {
         clear: left;
 }
-#buddypress label[for="select-all-notifications"] {
-        display: none;
-}
 #buddypress #notifications-bulk-management {
         clear: left;
 }

src/bp-templates/bp-legacy/js/buddypress.js

@@ -1538 +1538 @@
                 }
         });
 
+        /* Make sure a 'Bulk Action' is choosed before submiting the form */
+        jq('#notifications-bulk-management').on('submit', function(){
+                if ( jq(this).find('#notification-select').val() === '' ) {
+                        return false;
+                }
+        });
+
         /* Close site wide notices in the sidebar */
         jq('#close-notice').on( 'click', function() {
                 jq(this).addClass('loading');