Ticket #5451: 5451.isset.patch

src/bp-groups/classes/class-bp-groups-group.php

@@ -447 +447 @@
                                 return true;
 
                         default :
-                                return false;
+                                return (bool) $this->__get( $key );
                 }
         }
 

tests/phpunit/testcases/groups/class-bp-groups-group.php

@@ -1831 +1831 @@
                 $found = wp_list_pluck( $groups['groups'], 'id' );
                 $this->assertEqualSets( array( $g1, $g4 ), $found );
         }
+
+        /**
+         * @group magic
+         */
+        public function test_bp_groups_group_magic_isset_with_empty_check() {
+                $this->old_current_user = get_current_user_id();
+
+                $u = $this->factory->user->create();
+                $g = $this->factory->group->create( array( 'creator_id' => $u ) );
+
+                // Instantiate group object.
+                $this->set_current_user( $u );
+                $group = new BP_Groups_Group( $g );
+
+                // Assert ! empty() check is not false.
+                $this->assertNotFalse( ! empty( $group->is_member ) );
+
+                $this->set_current_user( $this->old_current_user );
+        }
 }
 
 /**