Ticket #5328: 5328.05.diff

bp-activity/bp-activity-classes.php

@@ -1145 +1145 @@
                                 $filter_sql[] = $sid_sql;
                 }
 
+                if ( ! empty( $filter_array['offset'] ) ) {
+                        $sid_sql = absint( $filter_array['offset'] );
+                        $filter_sql[] = "a.id >= {$sid_sql}";
+                }
+
                 if ( empty( $filter_sql ) )
                         return false;
 

bp-activity/bp-activity-filters.php

@@ -396 +396 @@
 
         return apply_filters( 'bp_activity_truncate_entry', $excerpt, $text, $append_text );
 }
+
+/**
+ * Include extra javascript dependencies for activity component.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @uses bp_activity_do_heartbeat() to check if heartbeat is required.
+ *
+ * @param array $js_handles The original dependencies.
+ * @return array $js_handles The new dependencies.
+ */
+function bp_activity_get_js_dependencies( $js_handles = array() ) {
+        if ( bp_activity_do_heartbeat() ) {
+                $js_handles[] = 'heartbeat';
+        }
+
+        return $js_handles;
+}
+add_filter( 'bp_core_get_js_dependencies', 'bp_activity_get_js_dependencies', 10, 1 );
+
+/**
+ * Add a just-posted class to avoid some mess in activity ajax pagination
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param string $classes
+ * @return string $classes
+ */
+function bp_activity_newest_class( $classes = '' ) {
+        $bp = buddypress();
+
+        if ( ! empty( $bp->activity->new_update_id ) && $bp->activity->new_update_id == bp_get_activity_id() ) {
+                $classes .= ' new-update';
+        }
+
+        $classes .= ' just-posted';
+        return $classes;
+}
+
+/**
+ * Use WordPress Heartbeat API to check for latest activity update.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @uses bp_activity_get_last_updated() to get the recorded date of the last activity
+
+ * @param array $response
+ * @param array $data
+ * @return array $response
+ */
+function bp_activity_heartbeat_last_recorded( $response = array(), $data = array() ) {
+        $bp = buddypress();
+
+        if ( empty( $data['bp_activity_last_id'] ) ) {
+                return $response;
+        }
+
+        $activity_latest_args = bp_parse_args(
+                bp_ajax_querystring( 'activity' ),
+                array( 'offset' => absint( $data['bp_activity_last_id'] ) + 1 ),
+                'activity_latest_args'
+        );
+
+        $newest_activities = array();
+        $last_activity_id = 0;
+
+        // temporarly adds a just_posted class for these activities
+        add_filter( 'bp_get_activity_css_class', 'bp_activity_newest_class', 10, 1 );
+
+        ob_start();
+        if ( bp_has_activities ( $activity_latest_args ) ) {
+
+                while ( bp_activities() ) {
+                        bp_the_activity();
+
+                        if ( $last_activity_id < bp_get_activity_id() ) {
+                                $last_activity_id = bp_get_activity_id();
+                        }
+
+                        bp_get_template_part( 'activity/entry' );
+                }
+
+        }
+        $newest_activities['activities'] = ob_get_contents();
+        $newest_activities['last_id']    = $last_activity_id;
+        ob_end_clean();
+
+        // remove the filter
+        remove_filter( 'bp_get_activity_css_class', 'bp_activity_newest_class', 10, 1 );
+
+        if ( ! empty( $newest_activities['last_id'] ) ) {
+                $response['bp_activity_newest_activities'] = $newest_activities;
+        }
+
+        return $response;
+}
+add_filter( 'heartbeat_received', 'bp_activity_heartbeat_last_recorded', 10, 2 );
+add_filter( 'heartbeat_nopriv_received', 'bp_activity_heartbeat_last_recorded', 10, 2 );
+
+/**
+ * Set the strings for WP HeartBeat API where needed.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param array $strings localized strings
+ * @return array $strings
+ */
+function bp_activity_heartbeat_strings( $strings = array() ) {
+
+        if ( ! bp_activity_do_heartbeat() ) {
+                return $strings;
+        }
+
+        // Check whether the global heartbeat settings already exist.
+        $heartbeat_settings = apply_filters( 'heartbeat_settings', array() );
+
+        $global_pulse = 0;
+
+        if ( ! empty( $heartbeat_settings['interval'] ) ) {
+                // 'Fast' is 5
+                $global_pulse = is_numeric( $heartbeat_settings['interval'] ) ? absint( $heartbeat_settings['interval'] ) : 5;
+        }
+
+        // Filter here to specify a BP-specific pulse frequency
+        $bp_activity_pulse = apply_filters( 'bp_activity_heartbeat_pulse', 15 );
+
+        /**
+         * Use the global pulse value unless:
+         * a. it doesn't exist, or
+         * b. the BP-specific value has been specifically filtered
+         */
+        if ( has_filter( 'bp_activity_heartbeat_pulse' ) || empty( $global_pulse ) ) {
+                $pulse = $bp_activity_pulse;
+        } else {
+                $pulse = $global_pulse;
+        }
+
+        $strings = array_merge( $strings, array(
+                'newest' => __( 'Load Newest', 'buddypress' ),
+                'pulse'  => $pulse,
+        ) );
+
+        return $strings;
+}
+add_filter( 'bp_core_get_js_strings', 'bp_activity_heartbeat_strings', 10, 1 );

bp-activity/bp-activity-functions.php

@@ -1849 +1849 @@
 function bp_embed_activity_save_cache( $cache, $cachekey, $id ) {
         bp_activity_update_meta( $id, $cachekey, $cache );
 }
+
+/**
+ * Should we use Heartbeat to refresh activities?
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @uses bp_is_activity_heartbeat_active() to check if heatbeat setting is on.
+ * @uses bp_is_activity_directory() to check if the current page is the activity
+ *       directory.
+ * @uses bp_is_active() to check if the group component is active.
+ * @uses bp_is_group_activity() to check if on a single group, the current page
+ *       is the group activities.
+ * @uses bp_is_group_home() to check if the current page is a single group home
+ *       page.
+ *
+ * @return bool True if activity heartbeat is enabled, otherwise false.
+ */
+function bp_activity_do_heartbeat() {
+        $retval = false;
+
+        if ( ! bp_is_activity_heartbeat_active() ) {
+                return $retval;
+        }
+
+        if ( bp_is_activity_directory() ) {
+                $retval = true;
+        }
+
+        if ( bp_is_active( 'groups') ) {
+                // If no custom front, then activities are loaded in group's home
+                $has_custom_front = bp_locate_template( array( 'groups/single/front.php' ), false, true );
+
+                if ( bp_is_group_activity() || ( ! $has_custom_front && bp_is_group_home() ) ) {
+                        $retval = true;
+                }
+        }
+
+        return $retval;
+}

bp-activity/bp-activity-template.php

@@ -454 +454 @@
  *           column in the database. The meaning of 'secondary_id' differs
  *           between components/types. Accepts a single ID, or an array of
  *           multiple IDs. Defaults to false.
+ *     @type int $offset Return only activity items with an ID greater than or
+ *           equal to this one. Note that providing an offset will disable
+ *           pagination. Default: false.
  *     @type string|bool $display_comments How to handle activity comments.
  *           Possible values:
  *             - 'threaded' - comments appear in a threaded tree, under their
@@ -543 +546 @@
                 'action'            => false,        // action to filter on e.g. activity_update, new_forum_post, profile_updated
                 'primary_id'        => $primary_id,  // object ID to filter on e.g. a group_id or forum_id or blog_id etc.
                 'secondary_id'      => false,        // secondary object ID to filter on e.g. a post_id
+                'offset'            => false,        // return only items >= this ID
 
                 'meta_query'        => false,        // filter on activity meta. See WP_Meta_Query for format
 
@@ -561 +565 @@
                 $display_comments = false;
         }
 
+        // Ignore pagination if an offset is passed
+        if ( ! empty( $offset ) ) {
+                $page = 0;
+        }
+
         if ( empty( $search_terms ) && ! empty( $_REQUEST['s'] ) )
                 $search_terms = $_REQUEST['s'];
 
@@ -632 +641 @@
         // into bp-custom.php or your theme's functions.php
         if ( isset( $_GET['afilter'] ) && apply_filters( 'bp_activity_enable_afilter_support', false ) )
                 $filter = array( 'object' => $_GET['afilter'] );
-        else if ( !empty( $user_id ) || !empty( $object ) || !empty( $action ) || !empty( $primary_id ) || !empty( $secondary_id ) )
-                $filter = array( 'user_id' => $user_id, 'object' => $object, 'action' => $action, 'primary_id' => $primary_id, 'secondary_id' => $secondary_id );
+        else if ( ! empty( $user_id ) || ! empty( $object ) || ! empty( $action ) || ! empty( $primary_id ) || ! empty( $secondary_id ) || ! empty( $offset ) )
+                $filter = array( 'user_id' => $user_id, 'object' => $object, 'action' => $action, 'primary_id' => $primary_id, 'secondary_id' => $secondary_id, 'offset' => $offset );
         else
                 $filter = false;
 
@@ -767 +776 @@
 function bp_activity_has_more_items() {
         global $activities_template;
 
-        $remaining_pages = floor( ( $activities_template->total_activity_count - 1 ) / ( $activities_template->pag_num * $activities_template->pag_page ) );
+        $remaining_pages = 0;
+
+        if ( ! empty( $activities_template->pag_page ) ) {
+                $remaining_pages = floor( ( $activities_template->total_activity_count - 1 ) / ( $activities_template->pag_num * $activities_template->pag_page ) );
+        }
+
         $has_more_items  = (int) $remaining_pages ? true : false;
 
         return apply_filters( 'bp_activity_has_more_items', $has_more_items );

bp-core/admin/bp-core-settings.php

@@ -104 +104 @@
 }
 
 /**
+ * Allow Heartbeat to refresh activity stream.
+ *
+ * @since BuddyPress (2.0.0)
+ */
+function bp_admin_setting_callback_heartbeat() {
+?>
+
+        <input id="_bp_enable_heartbeat_refresh" name="_bp_enable_heartbeat_refresh" type="checkbox" value="1" <?php checked( bp_is_activity_heartbeat_active( true ) ); ?> />
+        <label for="_bp_enable_heartbeat_refresh"><?php _e( 'Query automatically for new items when viewing the activity stream', 'buddypress' ); ?></label>
+
+<?php
+}
+
+/**
  * Sanitization for _bp_force_buddyvar
  *
  * If upgraded to 1.6 and you chose to keep the BuddyBar, a checkbox asks if you want to switch to

bp-core/bp-core-admin.php

@@ -330 +330 @@
                         add_settings_field( 'bp-disable-blogforum-comments', __( 'Blog & Forum Comments', 'buddypress' ), 'bp_admin_setting_callback_blogforum_comments', 'buddypress', 'bp_activity' );
                         register_setting( 'buddypress', 'bp-disable-blogforum-comments', 'bp_admin_sanitize_callback_blogforum_comments' );
 
+                        // Activity Heartbeat refresh
+                        add_settings_field( '_bp_enable_heartbeat_refresh', __( 'Activity auto-refresh', 'buddypress' ), 'bp_admin_setting_callback_heartbeat', 'buddypress', 'bp_activity' );
+                        register_setting( 'buddypress', '_bp_enable_heartbeat_refresh', 'intval' );
+
                         // Allow activity akismet
                         if ( is_plugin_active( 'akismet/akismet.php' ) && defined( 'AKISMET_VERSION' ) ) {
                                 add_settings_field( '_bp_enable_akismet', __( 'Akismet',          'buddypress' ), 'bp_admin_setting_callback_activity_akismet', 'buddypress', 'bp_activity' );

bp-core/bp-core-functions.php

@@ -1852 +1852 @@
 
         return $nav_item_url;
 }
+
+/**
+ * Get the javascript dependencies for buddypress.js.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @uses apply_filters() to allow other component to load extra dependencies
+ *
+ * @return array The javascript dependencies.
+ */
+function bp_core_get_js_dependencies() {
+        return apply_filters( 'bp_core_get_js_dependencies', array( 'jquery' ) );
+}
+

bp-core/bp-core-options.php

@@ -76 +76 @@
                 // Users from all sites can post
                 '_bp_enable_akismet'              => true,
 
+                /** Activity HeartBeat ************************************************/
+
+                // HeartBeat is on to refresh activities
+                '_bp_enable_heartbeat_refresh'    => true,
+
                 /** BuddyBar **********************************************************/
 
                 // Force the BuddyBar
@@ -586 +591 @@
 }
 
 /**
+ * Check whether Activity Heartbeat refresh is enabled.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @uses bp_get_option() To get the Heartbeat option.
+ *
+ * @param bool $default Optional. Fallback value if not found in the database.
+ *        Default: true.
+ * @return bool True if Heartbeat refresh is enabled, otherwise false.
+ */
+function bp_is_activity_heartbeat_active( $default = true ) {
+        return (bool) apply_filters( 'bp_is_activity_heartbeat_active', (bool) bp_get_option( '_bp_enable_heartbeat_refresh', $default ) );
+}
+
+/**
  * Get the current theme package ID.
  *
  * @since BuddyPress (1.7.0)

bp-templates/bp-legacy/buddypress-functions.php

@@ -223 +223 @@
                 // Enqueue the global JS, if found - AJAX will not work
                 // without it
                 if ( isset( $asset['location'], $asset['handle'] ) ) {
-                        wp_enqueue_script( $asset['handle'], $asset['location'], array( 'jquery' ), $this->version );
+                        wp_enqueue_script( $asset['handle'], $asset['location'], bp_core_get_js_dependencies(), $this->version );
                 }
 
                 // Add words that we need to use in JS to the end of the page
                 // so they can be translated and still used.
-                $params = array(
+                $params = apply_filters( 'bp_core_get_js_strings', array(
                         'accepted'            => __( 'Accepted', 'buddypress' ),
                         'close'               => __( 'Close', 'buddypress' ),
                         'comments'            => __( 'comments', 'buddypress' ),
@@ -242 +242 @@
                         'show_x_comments'     => __( 'Show all %d comments', 'buddypress' ),
                         'unsaved_changes'     => __( 'Your profile has unsaved changes. If you leave the page, the changes will be lost.', 'buddypress' ),
                         'view'                => __( 'View', 'buddypress' ),
-                );
+                ) );
                 wp_localize_script( $asset['handle'], 'BP_DTheme', $params );
 
                 // Maybe enqueue comment reply JS
@@ -480 +480 @@
                 $qs[] = 'exclude=' . implode( ',', $just_posted );
         }
 
+        // to get newest activities
+        if ( ! empty( $_POST['offset'] ) ) {
+                $qs[] = 'offset=' . intval( $_POST['offset'] );
+        }
+
         $object_search_text = bp_get_search_default_text( $object );
         if ( ! empty( $_POST['search_terms'] ) && $object_search_text != $_POST['search_terms'] && 'false' != $_POST['search_terms'] && 'undefined' != $_POST['search_terms'] )
                 $qs[] = 'search_terms=' . $_POST['search_terms'];
@@ -611 +616 @@
  * @since BuddyPress (1.2)
  */
 function bp_legacy_theme_post_update() {
+        $bp = buddypress();
+
         // Bail if not a POST action
         if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) )
                 return;
@@ -639 +646 @@
         if ( empty( $activity_id ) )
                 exit( '-1<div id="message" class="error"><p>' . __( 'There was a problem posting your update, please try again.', 'buddypress' ) . '</p></div>' );
 
-        if ( bp_has_activities ( 'include=' . $activity_id ) ) {
+        if ( ! empty( $_POST['offset'] ) && $last_id = absint( $_POST['offset'] ) ) {
+                $activity_args = array( 'offset' => $last_id );
+                $bp->activity->new_update_id = $activity_id;
+                add_filter( 'bp_get_activity_css_class', 'bp_activity_newest_class', 10, 1 );
+        } else {
+                $activity_args = array( 'include' => $activity_id );
+        }
+
+        if ( bp_has_activities ( $activity_args ) ) {
                 while ( bp_activities() ) {
                         bp_the_activity();
                         bp_get_template_part( 'activity/entry' );
                 }
         }
 
+        if ( ! empty( $last_id ) ) {
+                remove_filter( 'bp_get_activity_css_class', 'bp_activity_newest_class', 10, 1 );
+        }
+
         exit;
 }
 

bp-templates/bp-legacy/css/buddypress.css

@@ -290 +290 @@
         margin-left: 1em;
         white-space: nowrap;
 }
-#buddypress .activity-list li.load-more {
+#buddypress .activity-list li.load-more,
+#buddypress .activity-list li.load-newest {
         background: #f0f0f0;
         font-size: 110%;
         margin: 15px 0;
         padding: 10px 15px;
         text-align: center;
 }
-#buddypress .activity-list li.load-more a {
+#buddypress .activity-list li.load-more a,
+#buddypress .activity-list li.load-newest a {
         color: #4D4D4D;
 }
 

bp-templates/bp-legacy/js/buddypress.js

@@ -4 +4 @@
 // Global variable to prevent multiple AJAX requests
 var bp_ajax_request = null;
 
+// Global variables to temporarly store newest activities
+var newest_activities = '';
+var activity_last_id  = 0;
+
 jq(document).ready( function() {
         /**** Page Load Actions *******************************************************/
 
@@ -53 +57 @@
                 if ( $whats_new_form.hasClass("submitted") ) {
                         $whats_new_form.removeClass("submitted");       
                 }
+
+                // Return to the 'All Members' tab and 'Everything' filter,
+                // to avoid inconsistencies with the heartbeat integration
+                var $activity_all = jq( '#activity-all' );
+                if ( $activity_all.length  ) {
+                        if ( ! $activity_all.hasClass( 'selected' ) ) {
+                                // reset to everyting
+                                jq( '#activity-filter-select select' ).val( '-1' );
+                                $activity_all.children( 'a' ).trigger( "click" );
+                        } else if ( '-1' != jq( '#activity-filter-select select' ).val() ) {
+                                jq( '#activity-filter-select select' ).val( '-1' );
+                                jq( '#activity-filter-select select' ).trigger( 'change' );
+                        }
+                }
         });
 
         /* On blur, shrink if it's empty */
@@ -73 +91 @@
 
         /* New posts */
         jq("#aw-whats-new-submit").on( 'click', function() {
+                var last_displayed_id = 0;
                 var button = jq(this);
                 var form = button.closest("form#whats-new-form");
 
@@ -91 +110 @@
                 var object = '';
                 var item_id = jq("#whats-new-post-in").val();
                 var content = jq("#whats-new").val();
+                var firstrow = jq( '#buddypress ul.activity-list li' ).first();
+
+                if ( firstrow.hasClass( 'load-newest' ) ) {
+                        last_displayed_id = firstrow.next().prop( 'id' ) ? firstrow.next().prop( 'id' ).replace( 'activity-','' ) : 0;
+                } else {
+                        last_displayed_id = firstrow.prop( 'id' ) ? firstrow.prop( 'id' ).replace( 'activity-','' ) : 0;
+                }
 
                 /* Set object for non-profile posts */
                 if ( item_id > 0 ) {
@@ -104 +130 @@
                         'content': content,
                         'object': object,
                         'item_id': item_id,
+                        'offset': last_displayed_id,
                         '_bp_as_nonce': jq('#_bp_as_nonce').val() || ''
                 },
                 function(response) {
@@ -125 +152 @@
                                         jq("div.activity").append( '<ul id="activity-stream" class="activity-list item-list">' );
                                 }
 
+                                if ( firstrow.hasClass( 'load-newest' ) )
+                                        firstrow.remove();
+
                                 jq("#activity-stream").prepend(response);
-                                jq("#activity-stream li:first").addClass('new-update just-posted');
+
+                                if ( ! last_displayed_id )
+                                        jq("#activity-stream li:first").addClass('new-update just-posted');
 
                                 if ( 0 != jq("#latest-update").length ) {
                                         var l = jq("#activity-stream li.new-update .activity-content .activity-inner p").html();
@@ -149 +181 @@
                                 jq("li.new-update").hide().slideDown( 300 );
                                 jq("li.new-update").removeClass( 'new-update' );
                                 jq("#whats-new").val('');
+
+                                // reset vars to get newest activities
+                                newest_activities = '';
+                                activity_last_id  = 0;
                         }
 
                         jq("#whats-new-options").animate({
@@ -287 +323 @@
                                         li.children('#message').hide().fadeIn(300);
                                 } else {
                                         li.slideUp(300);
+
+                                        // reset vars to get newest activities
+                                        if ( activity_last_id == id ) {
+                                                newest_activities = '';
+                                                activity_last_id  = 0;
+                                        }
                                 }
                         });
 
@@ -311 +353 @@
                                         li.children( '#message' ).hide().fadeIn(300);
                                 } else {
                                         li.slideUp( 300 );
+                                        // reset vars to get newest activities
+                                        if ( activity_last_id == id ) {
+                                                newest_activities = '';
+                                                activity_last_id  = 0;
+                                        }
                                 }
                         });
 
@@ -353 +400 @@
 
                         return false;
                 }
+
+                /* Load newest updates at the top of the list */
+                if ( target.parent().hasClass('load-newest') ) {
+
+                        event.preventDefault();
+
+                        target.parent().hide();
+                        jq( '#buddypress ul.activity-list' ).prepend( newest_activities );
+
+                        // reset the newest activities now they're displayed
+                        newest_activities = '';
+                }
         });
 
         // Activity "Read More" links
@@ -1347 +1406 @@
         /* if js is enabled then replace the no-js class by a js one */
         if( jq('body').hasClass('no-js') )
                 jq('body').attr('class', jq('body').attr('class').replace( /no-js/,'js' ) );
-                
+
+
+        /** Activity HeartBeat ************************************************/
+
+        // Set the interval and the namespace event
+        if ( typeof wp != 'undefined' && typeof wp.heartbeat != 'undefined' && typeof BP_DTheme.pulse != 'undefined' ) {
+
+                wp.heartbeat.interval( Number( BP_DTheme.pulse ) );
+
+                jq.fn.extend({
+                        'heartbeat-send': function() {
+                        return this.bind( 'heartbeat-send.buddypress' );
+                },
+            });
+
+        }
+
+        // Set the last id to request after
+        jq( document ).on( 'heartbeat-send.buddypress', function( e, data ) {
+
+                // First row is default latest activity id
+                if ( jq( '#buddypress ul.activity-list li' ).first().prop( 'id' ) ) {
+                        firstrow = jq( '#buddypress ul.activity-list li' ).first().prop( 'id' ).replace( 'activity-','' );
+                } else {
+                        firstrow = 0;
+                }
+
+                if ( 0 == activity_last_id || Number( firstrow ) > activity_last_id )
+                        activity_last_id = Number( firstrow );
+
+                data['bp_activity_last_id'] = activity_last_id;
+        });
+
+        // Increment newest_activities and activity_last_id if data has been returned
+        jq( document ).on( 'heartbeat-tick', function( e, data ) {
+
+                // Only proceed if we have newest activities
+                if ( ! data['bp_activity_newest_activities'] ) {
+                        return;
+                }
+
+                newest_activities = data['bp_activity_newest_activities']['activities'] + newest_activities;
+                activity_last_id  = Number( data['bp_activity_newest_activities']['last_id'] );
+
+                if ( jq( '#buddypress ul.activity-list li' ).first().hasClass( 'load-newest' ) )
+                        return;
+
+                jq( '#buddypress ul.activity-list' ).prepend( '<li class="load-newest"><a href="#newest">' + BP_DTheme.newest + '</a></li>' );
+        });
 });
 
 /* Setup activity scope and filter based on the current cookie settings. */

tests/testcases/activity/class.BP_Activity_Activity.php

@@ -257 +257 @@
         }
 
         /**
+         * @group get
+         */
+        public function test_get_with_offset() {
+                $now = time();
+                $a1 = $this->factory->activity->create( array(
+                        'content' => 'Life Rules',
+                        'recorded_time' => date( 'Y-m-d H:i:s', $now - 100 ),
+                ) );
+                $a2 = $this->factory->activity->create( array(
+                        'content' => 'Life Drools',
+                        'recorded_time' => date( 'Y-m-d H:i:s', $now - 50 ),
+                ) );
+                $a3 = $this->factory->activity->create( array(
+                        'content' => 'Life Drools',
+                        'recorded_time' => date( 'Y-m-d H:i:s', $now - 10 ),
+                ) );
+
+                $activity = BP_Activity_Activity::get( array(
+                        'filter' => array(
+                                'offset' => $a2,
+                        ),
+                ) );
+                $ids = wp_list_pluck( $activity['activities'], 'id' );
+                $this->assertEquals( array( $a3, $a2 ), $ids );
+        }
+        /**
          * @group get_id
          */
         public function test_get_id_with_item_id() {