Group Admin Notifications and more than one private group request
|Reported by:||r-a-y||Owned by:|
Issue described here:
If a private group receives more than one membership request, the group admin user who logs in will see in their "Notifications" menu:
'2 new membership requests for the group ""'
The link for this notification goes nowhere:
The problem originates in the bp_core_notifications_for_user() function in "bp-core/bp-core-notifications.php".
Tentative fix requires changing these two lines:
$item_id = ( 1 == $action_item_count ) ? $component_action_items->item_id : false; $secondary_item_id = ( 1 == $action_item_count ) ? $component_action_items->secondary_item_id : false;
$item_id = $component_action_items->item_id; $secondary_item_id = $component_action_items->secondary_item_id;
I don't know why there was a check done for only 1 item and then returning false for more than 1... if a BP dev can explain why, that'd be great.