Opened 4 years ago

Closed 3 years ago

#845 closed defect (bug) (fixed)

bp_format_time outputs non-l10n date

Reported by: remi Owned by:
Priority: minor Milestone: 1.5
Component: Core Version:
Severity: Keywords: date i18n l10n has-patch
Cc:

Description

The bp_format_time function uses PHP's date function which doesn't care about WordPress WP_LANG constant.

Here's attached is a patch that replace its usage of date with WP's date_i18n function.

Attachments (2)

datei18n_20090711.diff​ (680 bytes) - added by remi 4 years ago.
845.patch​ (1.2 KB) - added by GIGALinux 4 years ago.

Download all attachments as: .zip

Change History (15)

remi — 4 years ago

comment:1   remi — 4 years ago

  • Summary changed from bp_format_time outpus non-l10n date to bp_format_time outputs non-l10n date

comment:2   remi — 4 years ago

  • Keywords date i18n l10n added

comment:3 follow-up: ↓ 4   apeatling — 4 years ago

Thanks will look into adding this soon. Could you check for other uses of date() in BuddyPress? I'm sure there are more than just this one.

comment:4 in reply to: ↑ 3   remi — 4 years ago

Replying to apeatling:

Thanks will look into adding this soon. Could you check for other uses of date() in BuddyPress? I'm sure there are more than just this one.

Found 24 other occurrences — will submit a new ticket/patch soon!

comment:5   apeatling — 4 years ago

  • Milestone set to 1.0.4

comment:6   GIGALinux — 4 years ago

  • Keywords has-patch added

Added patch

GIGALinux — 4 years ago

comment:7   apeatling — 4 years ago

  • Milestone changed from 1.0.4 to 1.1

Milestone 1.0.4 deleted

comment:8   apeatling — 4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1702]) Fixes #845

comment:9   apeatling — 4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Previous commit fixed #854 not this bug.

comment:10   apeatling — 4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [1726]) Fixes #845 props remi, GIGALinux

comment:11   DJPaul — 3 years ago

  • Component set to Core
  • Milestone changed from 1.1 to 1.3
  • Priority changed from major to minor
  • Resolution fixed deleted
  • Status changed from closed to reopened

Apparently this one has popped up again according to reports on the support site.

comment:13   djpaul — 3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3339]) Use date_i18n() instead of date() for output. Fixes #845 again.

Note: See TracTickets for help on using tickets.