Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#7857 closed defect (bug) (fixed)

Nouveau - Activity comments are hidden

Reported by: r-a-y's profile r-a-y Owned by: r-a-y's profile r-a-y
Milestone: 3.1.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch commit
Cc:

Description

There's a bug that hides all activity comments for being shown in Nouveau.

I have narrowed it down to this commit on Github:
https://github.com/buddypress/next-template-packs/commit/b1846eeef85b806fbf5d4cfa3efd1e61054079fc

The problem is due to a check for $( comment_parents ).find( 'li.show-all' ), which will return an object. If we want to check for the existence of li.show-all, we need to check the length of the object.

Attachments (1)

7857.01.patch (839 bytes) - added by r-a-y 6 years ago.

Download all attachments as: .zip

Change History (5)

@r-a-y
6 years ago

#1 @r-a-y
6 years ago

@imath - Can I get you to verify that this patch is okay?

#2 @imath
6 years ago

  • Keywords commit added

@r-a-y Sure :)

Green lights for me. Thanks a lot for your work : i can't believe i forgot the length in the check 🙄

#3 @r-a-y
6 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 12129:

Nouveau: Fix activity comments display in the activity stream.

Fixes #7857 (3.x branch).

#4 @r-a-y
6 years ago

In 12130:

Nouveau: Fix activity comments display in the activity stream.

Fixes #7857 (trunk).

Note: See TracTickets for help on using tickets.