#4771 closed defect (bug) (duplicate)
Show the Toolbar for logged out users | Toolbar not showing no matter what
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.7 |
| Component: | Core | Version: | 1.7 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
No matter whether checked or not checked the Toolbar doesn't show to logged out users.
Attachments (1)
Change History (10)
- Keywords has-patch added
- Milestone changed from Awaiting Review to 1.7
- Resolution set to fixed
- Status changed from new to closed
(In [6724]) Fix 'Show the Toolbar for logged out users' setting.
bp_core_load_admin_bar() uses the show_admin_bar() function; this
function toggles the WP toolbar visibiility.
WP recommends to use show_admin_bar() on 'plugins_loaded':
https://codex.wordpress.org/Function_Reference/show_admin_bar#Notes
Therefore, this commit changes when bp_core_load_admin_bar() runs
from 'bp_init' to 'bp_loaded'.
Fixes #4771.
I understand that you guys are perhaps still figuring this one out but I just wanted to let you all know that this hasn't been patched in the 1.7 beta 1. I've had to manually added the patch again after updating.
comment:6
boonebgorges — 3 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Hello. Sorry to keep going on about this but this issue still persists in the release version. I had to manually add the patch to make the bar appear.
- Keywords commit removed
- Resolution set to duplicate
- Status changed from reopened to closed
Confirmed.
According to the WP codex article, show_admin_bar() should be run on plugin loaded.
I've attached a patch that moves the BP admin bar loading from 'bp_init' to 'bp_loaded' and that fixes things.