Opened 6 months ago

Closed 6 months ago

#4711 closed defect (bug) (fixed)

Problem with group pagination count when users are excluded

Reported by: sbrajesh Owned by:
Priority: normal Milestone: 1.7
Component: Groups Version: 1.6.1
Severity: normal Keywords: has-patch
Cc:

Description

There is a problem with group pagination when some users are excluded using the exclude parameter in the bp_group_has_members(inside bp-default/groups/single/members.php)
It shows this message

`
Viewing member 1 to 0 (of 0 members)
`

The problem lies in Bp_Groups_Members::get_all_for_group method on line 1197.

The members table name is not aliased in the FROM clause but the alias m is used in the $exclude_sql.

Here is a patch attached again the BuddyPress 1.6 trunk. Need to check if we have same issue(might be) in 1.7 trunk too.

Attachments (1)

groups.total-member.patch​ (984 bytes) - added by sbrajesh 6 months ago.
patch for fixing the total members count of group when user is excluded

Download all attachments as: .zip

Change History (3)

sbrajesh — 6 months ago

patch for fixing the total members count of group when user is excluded

comment:1   johnjamesjacoby — 6 months ago

  • Milestone changed from Awaiting Review to 1.7

comment:2   johnjamesjacoby — 6 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6626]) Fix broken queries in bp-groups-classes.php.

  • Fixes misspelled variables.
  • Adds missing table alias. (props sbrajesh)
  • Some code clean-up.
  • Fixes #4711.
Note: See TracTickets for help on using tickets.