Opened 10 months ago

Closed 7 months ago

#4417 closed defect (bug) (fixed)

Fix notice in bp-groups-loader.php

Reported by: r-a-y Owned by:
Priority: normal Milestone: 1.6.2
Component: Groups Version: 1.6
Severity: normal Keywords: has-patch
Cc:

Description

On lines 505-507 of bp-groups-loader.php:
​https://buddypress.trac.wordpress.org/browser/tags/1.6/bp-groups/bp-groups-loader.php#L500

$count is not an object; it's actually an array.

This causes a "Trying to get property of non-object" notice.

Attached patch fixes this.

Attachments (1)

4417.01.patch​ (931 bytes) - added by r-a-y 10 months ago.

Download all attachments as: .zip

Change History (7)

r-a-y — 10 months ago

comment:1   r-a-y — 10 months ago

Just to further note, I experienced this notice when I'm logged in as a regular user with a group invite.

comment:2   DJPaul — 9 months ago

  • Milestone changed from Awaiting Review to 1.7

comment:3   djpaul — 8 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6353]) Fix notice in bp-groups-loader.php. Fixes #4417, props r-a-y

comment:4   boonebgorges — 7 months ago

  • Milestone changed from 1.7 to 1.6.2

This error breaks the invite count in the menu (in addition to causing a warning), so it should probably be fixed in the branch.

comment:5   boonebgorges — 7 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:6   boonebgorges — 7 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6481]) Use correct data type when access group count in the My Groups > Invites admin bar menu

Applies r6353 to 1.6 branch. Fixes #4417

Note: See TracTickets for help on using tickets.