WP 3.4/BP1.5.6 – issue with quotes on SWA

[chouf1]

In the WP mo file there is a translation for curly quot opening and closing quot 8220 and 8221 to respectively laquo and raquo

This is welle translated in forum post and comments, and NOT in the site wide activity witch ouput 2 closing quote.

The only way actually is to not translate the quote and using the original 8220/8221, but this gives english quotes; In french we use laquo and raquo.

I searched and tried many things, but couldn’t isolate the origin who sits probably between wp-includes/formating.php and buddypress/…/…/backpress/functions_kses.php and some filter in bp-activity-filter.php

The wrong things are the two closing quotes in french.
For better understanding you can read here, but’s in french:

​http://bp-fr.net/groups/utilisation-configuration-optimisation-de-buddypress/forum/topic/probleme-de-guillemet-dans-buddypress#post-4986

This problem was also under WP 3.3.2/BP 1.5.4

Here a comment on group activity showing the 2 closing french quotes
​http://bp-fr.net/groups/utilisation-configuration-optimisation-de-buddypress/forum/topic/probleme-de-guillemet-dans-buddypress#post-4976

chouf1, can you look at #4297 -- might this be your problem? Do the wrong quotes always appear, or is it only when they are loaded/posted with AJAX?

I'm afraid I'm unable to reproduce this. chouf1, can you give exact details on how to reproduce the issue? When I put the following text into an activity update, it works fine:

Je teste les « guillemets » français

The guillemets come though my activity stream looking just fine. (WP 3.4.1, BP 1.5.x/trunk)

Hello Boone and DJPaul,

i actually use bp 1.5.6 standart and WP 3.4.1 french edition.
The problem sits in WP, i guess because BP looks fine now.

Before latest update, I changed the WP 3.3.2 translation for curly quotes from 8220 to « (alt+0171) to have something correct.

This is what you can see under the link i give in my first post here.

Since update to 3.4.1 (with use of the original FR translation) quotes seems to be correctly outputed. That said, this FR translation missed the closing curly cote in the 3.3.2 version)

When posting on a forum, the quotes are OK for now. But inserting code with tags or bakcsticks in a forum post or an answer is completly weird. Same thing in blog post and comments.

To reproduce, try with this exemple with php and html who looks awfull:

Posting some code inside backsticks
`if(bp_use_wp_admin_bar())
    return bpln_get_notifications_for_wpadminbar();
	$html= '<li id="bp-adminbar-notifications-menu"><a href="' . $bp->loggedin_user->domain . '">';
	$html.=__( 'Notifications', 'buddypress' );

	if ( $notifications = bp_core_get_notifications_for_user( $bp->loggedin_user->id ) )
            $html.="<span>".count( $notifications )."</span>";`

Posting code using pre tag
<pre>if(bp_use_wp_admin_bar())
    return bpln_get_notifications_for_wpadminbar();
	$html= '<li id="bp-adminbar-notifications-menu"><a href="' . $bp->loggedin_user->domain . '">';
	$html.=__( 'Notifications', 'buddypress' );

	if ( $notifications = bp_core_get_notifications_for_user( $bp->loggedin_user->id ) )
            $html.="<span>".count( $notifications )."</span>";</pre>

Posting code using code tag
<code>if(bp_use_wp_admin_bar())
    return bpln_get_notifications_for_wpadminbar();
	$html= '<li id="bp-adminbar-notifications-menu"><a href="' . $bp->loggedin_user->domain . '">';
	$html.=__( 'Notifications', 'buddypress' );

	if ( $notifications = bp_core_get_notifications_for_user( $bp->loggedin_user->id ) )
            $html.="<span>".count( $notifications )."</span>";</code>

You can see it here in a blog post
​http://bp-fr.net/2012/07/probleme-de-quotes/
And here in a forum topic
​http://bp-fr.net/groups/utilisation-configuration-optimisation-de-buddypress/forum/topic/probleme-de-quotes-bis-repetita/

Output changes a little bit if i remove those filters via functions.php

remove_filter( 'bp_get_the_topic_latest_post_excerpt', 'bp_forums_filter_kses', 1 );
remove_filter( 'bp_get_the_topic_post_content', 'bp_forums_filter_kses', 1 ); 

Even if this ticket looks as a WP problem, it seems to me that there is somwhere a double filtering by calling a WP filter and adding a BP filter (or more). ?!!!

Oups, forgot to give you the way to reproduce
Write something between quotes with no space and with space
"test" and " test "

The first one is correct, the second shows 2 closing quotes.

Is correct on the forum activity
View here in the reply
​http://bp-fr.net/groups/utilisation-configuration-optimisation-de-buddypress/forum/topic/probleme-de-quotes-bis-repetita

Is not correct on the swa, nore in a swa comment

Moving to future release for further investigation

Hi,

If you add spaces between the quote and the word, then wptexturize inverse the quotes, i think it's a WordPress trouble.
example : " guillemets " will be filtered this way : » guillemets « by wptexturize in an activity or a post...

The only thing BuddyPress can look at is the priority of wptexturize. In 1.7, if you post an activity with no space between the quote and the word, then you have this : »guillemets ». In a WordPress post, the quotes are ok.

If wptexturize is applied after stripslashes_deep, then the quotes are ok like on a WordPress post. I suggest the 4265.diff attached to this ticket.

Let's see if we can figure this out for BP 1.8