Opened 15 months ago
Closed 11 months ago
#4038 closed task (fixed)
Edit Member toolbar javascript still fires when clicking cancel
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | high | Milestone: | 1.6 |
| Component: | Settings | Version: | 1.5.4 |
| Severity: | major | Keywords: | |
| Cc: |
Description
When you spam or delete a user via the Edit Member toolbar item, clicking cancel still performs the action. I elect we ditch the alert all together for more robust templates that give us more control over a users status and capabilities for later.
Change History (6)
(We need to kept the javascript itself in the theme for compat with other places in BP-Default, as well as third-party plugins/themes that make use of it.)
JJJ, is this complete? The Toolbar's Edit Member button no longer uses the javascript, and the other confirm prompts that I can find (e.g. delete an activity item) function correctly.
- Resolution set to fixed
- Status changed from new to closed
I'm going to close this ticket as complete; the edit member toolbar javascript alert has been removed per r5829, and I can't find any more confirm(), with the exception of one in the Activity admin screen which I believe should stay.
Let's open new individual tickets if any more instances come up.

(In [5829]) First pass at adding user capabilities screen and action to settings component: