default settings are incorrect

[DJPaul]

On a clean install of WP + BP (non-multisite), after completing the set up wizard, accepting the defaults, the settings panel shows some strange defaults. Previous versions of BP allow avatar upload and account deletion and group creation by default, so I'm calling this a bug.

Screenshot attached.

Our BP 1.5 option names as set in bp_get_default_options() are different from what is used in the settings screen markup in register_admin_settings(), of which the latter has a decidedly bbPress-inspired naming convention. Need to decide which to use, and handle any setting migration as necessary.

(In [5937]) Register correct setting name for Activity Akismet. See #4008.

Probably too late to go on an option renaming spree. Let's match them to their old (and incorrectly hyphenated) counterparts.

Probably too late to go on an option renaming spree. Let's match them to their old (and incorrectly hyphenated) counterparts.

+1. Much easier for now.

When this is done, the phpdoc for the Settings component needs an overhaul as there's a lot of copy/paste remnants from bbPress.

(In [6026]) Remove a bunch of admin screen helper functions which came from bbPress. See #4008

(In [6037]) Remove duplicate (and unused) db version string. See #4008

Please would someone eyeball and test 4008-1.patch. You'll need to test upgrades from 1.5, with different combinations of settings turned on/off.

I've assumed that we want the settings labelled as they are in trunk, which is why I've put some logic in the upgrade_1_6() method to flip the values around.

(In [6038]) Remove unused admin dashboard CSS which came from bbPress. See #4008

I'll try to have a look at 4008-1.patch in the next few days.

Switching back and forth from 1.5.5 to trunk-6058, everything looks fine here...

Here are 3 'Settings' screenshots in 1.6 after changing settings in 1.5.5:

shanebp-1.png: 1.5.5 defaults to 1.6

shanebp-2.png: 1.5.5 all off to 1.6

shanebp-3.png: 1.5.5 with avatar uploads and delete accounts set to 'No' to 1.6

I didn't have any forums enabled for any of these.

More testing? Better testing? Lemme know.

(In [6066]) Remove some more copypasta that came from/belongs in bbPress. See #4008.

• The 'Root forum ID for groups' belongs to bbPress.
• Don't serialise 'bp-deactivated-components'.
• Remove 'Use WP Editor' option until/if we decide to integrate TinyMCE into any BP component.

Thanks for testing shanebp

(In [6067]) Correct BuddyPress core settings values when upgrading from 1.5 to 1.6. Fixes #4008

My last commit is all bad.

(In [6078]) Revert part of r6067. See #4008, antiprops DJPaul

This still isn't fixed. On a clean non-ms install, the following options are not ticked in the UI:

Account Deletion, Avatar Uploads, Group Creation

(In [6145]) Fix default settings being set incorrectly on a clean install. Fixes #4008 again