Opened 20 months ago
Closed 20 months ago
#3580 closed enhancement (fixed)
BuddyPress 1.5 Upgrade "Repair" message has conflicting (or potentially confusing) terms
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | 1.5 |
| Component: | UX/UI | Version: | 1.5 |
| Severity: | trivial | Keywords: | |
| Cc: |
Description
I'm attaching a screenshot to show this, but in the Repair notice you are told that you need pages to support the "Activate" and "Register" components.
Then below the components are referred to as "Sign-up" and "Activation". Why not make them the same and avoid potential confusion.
Attachments (2)
Change History (7)
masonjames — 20 months ago
comment:1
masonjames — 20 months ago
- Version set to 1.5
comment:2
boonebgorges — 20 months ago
- Milestone changed from Awaiting Review to 1.5
- Priority changed from normal to trivial
- Severity changed from normal to trivial
I think that probably the lower text should be changed to match the upper. Any objections?
Agree. I also noticed that, on non-multisite, the nag doesn't display for the activation/registration "components" when they haven't been mapped to a page. This is because multisite and regular WordPress use different option keys for enabling/disabling user registration. I'd like to change $bp->site_optionsregistration? to $bp->site_optionsusers_can_register? as multisite has a option_ filter… but I'm not 100% confident that swapping that wouldn't break something else at this point, so the patch has a safe fix, but I'd love a second opinion.
comment:4
boonebgorges — 20 months ago
+1 on the patch for the moment - only cosmetic changes at this point, unless they're critical.
Screenshot