Opened 22 months ago
Last modified 5 weeks ago
#3388 new enhancement
Allow @mentions to be disabled
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.8 |
| Component: | Activity | Version: | 1.5 |
| Severity: | normal | Keywords: | has-patch needs-refresh |
| Cc: | vpundir@… |
Description
BuddyPress No Mentions by r-a-y handles this well, but with over 2,000 downloads in less than a year it seems like a good candidate for core adoption. I've included two patches, one with an option added to the BP settings page, the other is a filter only scenario. I've added the bp_activity_do_mentions() function to bp-activity-filters.php because bp-activity-functions.php wasn't being loaded early enough, and I wasn't sure about changing load order.
Attachments (3)
Change History (12)
comment:1
boonebgorges — 22 months ago
- Keywords dev-feedback added
I like the idea of including something like this. Don't think we need an admin option, personally, so I would go with the first option. Only question is milestone - do we squeeze into 1.3? Other core devs chime in?
I agree that the filter would be better, but wanted to cover my bases. Also, I'm updating the filter only patch. It was defaulting to mentions disabled.
- Type changed from defect to enhancement
I don't mind a filter in core, but I personally think that DTheme should showcase all of BuddyPress' best features, and I think @messaging is one of them (= no conditional changes in DTheme). This is an enhancement not a defect, and now we are in beta, it should go to a future release.
comment:4
boonebgorges — 22 months ago
- Milestone changed from Awaiting Review to Future Release
I personally think that DTheme should showcase all of BuddyPress' best features, and I think @messaging is one of them
Fair enough. This is a good argument for not having the conditional in bp-default.
Moving to Future Release, which should get a good going-through after the 1.5 release.
- Milestone changed from Future Release to 1.7
Let's reconsider as we build the theme compat stuff; if nothing else, we can get a filter in.
comment:6
sooskriszta — 6 months ago
- Cc vpundir@… added
Admin option would be great!
Personally, as a site-owner (as opposed to developer), I find filter-only features hard to reconcile with...it feels like the heavy lifting has already been done in the back-end but the last mile hasn't been built rendering the feature useless to most users...
comment:7
modemlooper — 6 months ago
you can turn this off by adding a code snippet or using bp extended settings plugin.
comment:8
johnjamesjacoby — 5 months ago
- Milestone changed from 1.7 to 1.8
Looks like 3388.002.diff went stale. Let's get a refresh in for 1.8?
comment:9
boonebgorges — 5 weeks ago
- Keywords needs-refresh added; dev-feedback removed
I think cnorris23's patches are good, but need refreshing to be included in 1.8. (No whitespace fixes, please.)
filter only