Opened 3 years ago
Closed 3 years ago
#2556 closed defect (bug) (fixed)
”Send To” Drop-down Box Error in ”Compose Message”
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.5 |
| Component: | Messaging | Version: | 1.5 |
| Severity: | Keywords: | has-patch needs-testing | |
| Cc: | herostrat |
Description (last modified by DJPaul)
When I try to use the “Compose Message” page, I get an error in the drop-down box of the “Send To” field.
The drop down box displays things like
el=”alternate” type=”application/rss+xml” title=”Fan Club
Attachments (3)
Change History (11)
- Keywords reporter-feedback added
Does this still occur in BP 1.2.6?
Have you tried this in other browsers?
- Keywords has-patch added; reporter-feedback removed
- Version set to 1.3
Patch against 1.3-bleeding.
Fix provided by herostrat and Ian Arkin:
http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/bp-messages-compose-message-autocomplete-issue/#post-82498
http://buddypress.org/community/groups/requests-feedback/forum/topic/message-send-to-autocomplete-and-other-problems-fix/
Might want to patch on the 1.2 branch as well.
- Description modified (diff)
- Keywords needs-testing added
I'm not sure this patch will work when WordPress is installed in a subdirectory; I think it will construct the wrong URL. I assume this is why SCRIPT_NAME is used here. We need to identify what the actual cause of this problem is. Does $_SERVERSCRIPT_NAME? not always contain "index.php"?
1.2 branch is awaiting release, we're not adding anything more to it.
Just checked against a root and a subdomain install (WP 3.0.3):
Actually this patch is _necessary_ to make it work in a subdirectory. In a subdirectory install the current code constructs the URL like:
http://DOMAIN/SUBDOMAIN/SUBDOMAIN/wp-load.php
$bp->root_domain part:
http://DOMAIN/SUBDOMAIN/
str_replace( 'index.php', 'wp-load.php', $_SERVERSCRIPT_NAME? ) part:
SUBDOMAIN/wp-load.php
The proposed patch constructs the right path for root and subdirectory installs, so +1 for patching...
Paul is right.
Just tested this with Wordpress installed in a subdirectory:
http://codex.wordpress.org/Giving_WordPress_Its_Own_Directory
And patch-001 doesn't address this.
Patch-002 should address this.
Tested where WP is installed in a subdirectory and on a network subdirectory install where BP_ROOT_BLOG = 2.
I really hate the way we inject javascript inline with messages_autocomplete_init_jsblock(); I think Boone said he was going to re-work the autocomplete javascript at some point, so I'll leave it to him to improve that.

screenshot of the dropdown box