Opened 3 years ago

Last modified 2 months ago

#2372 reopened enhancement

@mention in wordpress post comment

Reported by: intimez Owned by:
Priority: normal Milestone: 1.8
Component: Blogs Version: 1.5
Severity: normal Keywords: has-patch
Cc: mercijavier@…

Description

If a person is @mention on the buddypress side, it will send an email notification if enabled.

This does not happen when leaving a comment on a wordpress post.

Is there any way to tie it to the buddypress system or even have a wordpress post recognize it as a buddypress command?

Attachments (1)

2372.01.patch (648 bytes) - added by r-a-y 2 months ago.

Download all attachments as: .zip

Change History (9)

  • Type changed from enhancement to defect

It correctly link to the buddypress profile so from that we know it's picking it up but no notification is sent.

  • Resolution set to invalid
  • Status changed from new to closed

As you confirm, @-mention linking is already working correctly.

Notifications for @-mentions were added is [3403]

  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Version set to 1.3

@boonebgorges

I've tested this using trunk r3717 and it's not working.

Is 3403 for wordpress comment or only for buddypress? It sounds like only for buddypress so I'm reopening as my defect report is different.

  • Milestone changed from 1.3 to 1.4
  • Type changed from defect to enhancement

You're right, this should be added. Switching to an enhancement and bumping to 1.4, as it's unlikely that the core team will have time to tackle this for 1.3.

  • Cc djpaul removed
  • Keywords @mention comment notification removed
  • Milestone changed from 1.6 to Future Release
  • Severity set to normal

Currently, the way that content like blog comments is this:

  • They are processed as activity items, which contain an excerpt of the first sentence or two of the original content (eg, the comment)
  • If that excerpt contains an @-mention, then notifications will be processed. If the @-mentions appear after the excerpt cut, then nothing happens.

Ideally, we would be more consistent about how this works - generating @-mentions from the original content, or perhaps even storing all original content in the activity table - but that would require a substantial rewrite of the way that @-mentions are processed.

  • Cc mercijavier@… added

r-a-y2 months ago

  • Component changed from Core to Blogs
  • Keywords has-patch added
  • Milestone changed from Future Release to 1.8

Attached a patch to fix this problem.

Tentatively moving to 1.8, but could make its way back to 1.7 if the other devs agree.

Definitely not for 1.7. I don't know if there would be negative repercussions from storing all blog content in wp_bp_activity like this. Needs more research.

Note: See TracTickets for help on using tickets.