Make login dialog a widget

[jivany]

In the 1.2-bleeding bp-default theme, the login dialog at the top of the right column is static. Would it be possible to turn it into a widget instead?

The trouble is, it needs to always be there. Otherwise there isn't a theme based login anywhere else. I think if people really want to change this they can edit the sidebar.

Reopening another ticket... sorry DJPaul!

I think you can create a login widget and if the widget sidebar is empty, it will show the static login block by default.

A lot WP themes do this "if empty widget sidebar, show default blocks".

Again, 1.2 is in feature-freeze. If you're reopening stuff please be sure to assign future milestones.

Sorry about that, DJPaul.

Here's a very simple patch to make the login/logout box into a widget.

In order to maintain consistency with the way that the login currently looks, I wanted to get rid of the before_widget etc stuff. Instead of removing it in the markup (so that there'd be no way for a themer to style it) I wrote a filter that unsets those values before the widget is rendered. It's a little clumsy, but it seems like a fair compromise.

Feedback welcome.

I think removing the login form from the markup would be good.

I'd propose changing the code into a template tag and add a filter. Mostly thinking of BP Template Pack theme developers who'd want to hard-code a login widget to their sidebar.

The widget can then reference this template tag.

WP's default search widget does something similar to what I'm proposing with get_search_form():
​http://codex.wordpress.org/Function_Reference/get_search_form

However, WP also adds a template file specifically for the search form. An extra template file could be overkill.

Thoughts?

---

Also widget name needs to be editable.

I wanted to replace all of the log in template with the wp_login_form() helper, but unfortunately that doesn't let me set the form's class, and there's nothing convenient nearby we can apply the standard-form class to. Maybe we can do this in BuddyPress 1.4.

I'm against putting a log in widget in core unless it is somehow BuddyPress-specific; there are plenty of log in widget plugins on the wordpress.org site.

BP 1.7 is a good time to implement this, because we'll be going theme-independent. Easy props if someone can port our code to a widget. (My patch above might need refreshing.)

I'll do it :D

Going through code, noticed there is no bp-members-widgets.php. There is a bp-groups-widget.php in /bp-groups with the groups widget code there.

Shouldn't the members widgets reside in /bp-members/bp-members-widgets.php? Also, what happened to the activity widget?

testing patches, never done this :D

Replying to modemlooper:

Also, what happened to the activity widget?

Huh. It looks like it was removed in 1.2-beta. Don't know why.

Let's try to get to this for 1.8. The plan is to port bbPress' widget. Should be an easy-ish patch for someone.